phpBB 3.3.4-RC1 released

[Marc]

Release highlights

• Notable Improvements
  • Increased compatibility with PHP 8
  • Support for WEBP images
  • Improved wording of email templates
• Notable Changes
  • Support for custom error messages in CAPTCHAs
• Notable Bugfixes
  • SQL error in ACP if database name contains a dash

The packages can be downloaded from our package archive or the Area51 downloads page. Please test the packages to extent, so we can have a fail-save final release.

• https://gist.github.com/marc1706/fbb369 ... bf6900cff8 Language changes
• https://gist.github.com/marc1706/4eba4d ... a79c76557b Prosilver changes

[Onnozel Manneke]

Thank you all! Forum succesfully updated with the full package.

Just got this:

Code: Select all

[phpBB Debug] "Constant PHPBB_ENVIRONMENT already defined" in file /var/www/vhosts/onnozelmanneke.space/httpdocs/config.php on line 15

And in ACP - General I see:




"Board version" is not using the language string from the NL language. It it present in /nl/acp/common.php

Code: Select all

	'BOARD_VERSION'		=> 'Forumversie',

[P_I]

Two data points to report using my localhost testing environment and following the steps in https://www.phpbb.com/support/docs/en/3 ... date_full/

On a CentOS 8 (Stream) server, with PHP 7. 4.16, the update went smoothly and no issues reported or seen so far during post-update sanity testing.

On a CentOS 7.9 server, with PHP 8.0.3, I'm also getting the following message during the database update process.

Code: Select all

[phpBB Debug] "Constant PHPBB_ENVIRONMENT already defined" in file /var/www/html/forum/config.php on line 15

The config.php file on each server is identical

Code: Select all

<?php
// phpBB 3.3.x auto-generated configuration file
// Do not change anything in this file!
$dbhost = 'localhost';
$dbport = '';
$dbname = 'database';
$dbuser = 'user';
$dbpasswd = password';
$table_prefix = 'phpbb_';
$dbms = 'phpbb\\db\\driver\\mysqli';
$acm_type = 'phpbb\\cache\\driver\\file';
$phpbb_adm_relative_path = 'adm/';

@define('PHPBB_INSTALLED', true);
@define('PHPBB_ENVIRONMENT', 'production');
//@define('DEBUG_CONTAINER', true);

The actual update is working and no issues seen so far during post-update sanity testing.

I've performed the update with PHP 8 twice now, the first time I'd forgotten (because it isn't mentioned in the instructions) to disable extensions before updating and the Scroll Quoted Text extension was throwing a PHP debug error. Disabling and enabling the extension cleared the error.

[Onnozel Manneke]

On a CentOS 7.9 server, with PHP 8.0.3, I'm also getting the following message during the database update process.

Code: Select all

[phpBB Debug] "Constant PHPBB_ENVIRONMENT already defined" in file /var/www/html/forum/config.php on line 15

Yeah, same: CentOS 7.9 server, with PHP 8.0.3

[3Di]

This shouldn't happen on a fresh install but just on update, I think.

Changing a line in config.php prior to perform the update should solve the above bug.
In any case is not relevant and not a major bug.

From

Code: Select all

@define('PHPBB_ENVIRONMENT', 'production');

to

Code: Select all

if (!defined('PHPBB_ENVIRONMENT'))
{
	define('PHPBB_ENVIRONMENT', 'production');
}

Proof of concept:

[P_I]

@3Di, should this regression be reported in tracker?

To the best of my knowledge there is no expectation that admins make changes to config.php once a system has been installed and is running.

Any admins using PHP 8 and upgrading to 3.3.4 are going to be surprised by this debug message.

[DavidIQ]

Should report it. Seems like maybe config.php is somehow getting re-included somewhere for PHP 8.

[P_I]

From a quick glance I believe the problem is how the fix for https://tracker.phpbb.com/browse/PHPBB3-16719 was implemented.

[DavidIQ]

I think that fix addresses a possible cause, but it apparently may not be the only cause. Can you just make sure your install/app.php file has this in it:

Code: Select all

if (!defined('PHPBB_ENVIRONMENT'))
{
	define('PHPBB_ENVIRONMENT', 'production');
}

[P_I]

It does, here is the top of phpBB3/install/app.php from my 3.3.4-RC1 full package

Code: Select all

<?php
/**
 *
 * This file is part of the phpBB Forum Software package.
 *
 * @copyright (c) phpBB Limited <https://www.phpbb.com>
 * @license GNU General Public License, version 2 (GPL-2.0)
 *
 * For full copyright and license information, please see
 * the docs/CREDITS.txt file.
 *
 */

/**
 * @ignore
 */
define('IN_PHPBB', true);
define('IN_INSTALL', true);
if (!defined('PHPBB_ENVIRONMENT'))
{
        define('PHPBB_ENVIRONMENT', 'production');
}
$phpbb_root_path = '../';
$phpEx = substr(strrchr(__FILE__, '.'), 1);

if (version_compare(PHP_VERSION, '7.1.3', '<'))
{
        die('You are running an unsupported PHP version. Please upgrade to PHP 7.1.3 or higher before trying to install or update to phpBB 3.3');
}