DocBlocks

[Kailey]

Agree on all points except #2.

[3Di]

I'm also for the gap to separate different types.

@3Di: The @access specifier is still a legacy from the old days when this couldn't be properly defined and is no longer needed (and therefore should also no longer be used).

Ah, good to know thx.

[martti]

As PHP 7.1 is the lowest supported version for phpBB 3.3.x I'm for setting all the parameter and return types directly in the code and then for removing all DocBlocks that don't add extra value or information (or even could be misleading when they go out of sync with the code).

https://localheinz.com/blog/2018/05/06/ ... docblocks/

Also, you can make phpBB strictly typed by adding declare(strict_types=1); at the top of all PHP files. That will huge a benefit in making the code solid and clear. Errors are then thrown on type violations.

https://dev.to/robdwaller/how-php-type- ... -work-1mm5

[DavidIQ]

That first one is pretty much an opinion piece. Dev team can decide on how docblocks are used moving forward though. Probably wouldn't do that second one until at least 5.0 way in the future. It would be very disruptive to current development and doesn't really buy us much.

[JoshyPHP]

You can use strict_types on new files while preserving compatibility with the less type-aware parts of the codebase.

[DavidIQ]

Ah that's true 👍🏼