PHPBB3-15097 - Board statistics page should show PHP version

Discuss requests for comments/changes posted in the Issue Tracker for the development of phpBB. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
P_I
Registered User
Posts: 69
Joined: Fri Oct 31, 2014 4:56 am

PHPBB3-15097 - Board statistics page should show PHP version

Post by P_I » Fri Feb 17, 2017 8:25 pm

New contributor here who needs some guidance. I created the above ticket and I'd like to make my first contribution to fix phpBB 8-) I've previously only used git to clone repositories for use, not for making any code changes.

I'm following the process outlined in Git — phpBB 3.1.x documentation and I've successfully gotten to the Bug fixing stage, in particular I've completed the # Make your changes step and have tested the changes on my localhost.

There are three files changed in my bugfix, I've use git add to stage the files per the instructions. Now the biggie, git commit which states
Git — phpBB 3.1.x documentation wrote:please use a correct commit message
but gives no guidance on what is expected and is correct. Help please the newcomer make a good impression. What's expected here?

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: PHPBB3-15097 - Board statistics page should show PHP version

Post by DavidIQ » Fri Feb 17, 2017 8:27 pm

Scroll up a bit from that line you quoted:
https://area51.phpbb.com/docs/dev/31x/d ... t-messages
Image

User avatar
P_I
Registered User
Posts: 69
Joined: Fri Oct 31, 2014 4:56 am

Re: PHPBB3-15097 - Board statistics page should show PHP version

Post by P_I » Fri Feb 17, 2017 8:33 pm

D'oh.
While I have your attention, here's my proposed new Board statistics section showing the PHP version.
PHPBB3-15097 fix.PNG
My concern is the table now contains an odd number of entries. Is that OK or should the empty row/column contain a &nbsp?

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: PHPBB3-15097 - Board statistics page should show PHP version

Post by DavidIQ » Fri Feb 17, 2017 8:38 pm

I would swap the PHP version with the Board version. Wouldn't really worry about the blank space. We could add some additional data to the list later like "Active extensions" or something.
Image

User avatar
P_I
Registered User
Posts: 69
Joined: Fri Oct 31, 2014 4:56 am

Re: PHPBB3-15097 - Board statistics page should show PHP version

Post by P_I » Fri Feb 17, 2017 8:43 pm

I thought of that, but there's conditional code around Board version and Orphaned attachments that I didn't want to disturb.

User avatar
P_I
Registered User
Posts: 69
Joined: Fri Oct 31, 2014 4:56 am

Re: PHPBB3-15097 - Board statistics page should show PHP version

Post by P_I » Fri Feb 17, 2017 9:10 pm

I think I've followed all the steps correct and we're now at https://github.com/phpbb/phpbb/pull/4705 and I added it to https://tracker.phpbb.com/browse/PHPBB3-15097.

Am I done? What's next?

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: PHPBB3-15097 - Board statistics page should show PHP version

Post by DavidIQ » Fri Feb 17, 2017 9:13 pm

Yeah so your commit message is wrong. The branch part was referring to the branch you're working on, which should have been ticket/15097 so the beginning of your commit message should have had [ticket/15097] and not [3.1.x]. You only have one commit there so should be easy enough to change the commit message and force push.
Image

User avatar
P_I
Registered User
Posts: 69
Joined: Fri Oct 31, 2014 4:56 am

Re: PHPBB3-15097 - Board statistics page should show PHP version

Post by P_I » Fri Feb 17, 2017 9:26 pm

I think I've fixed it. I made a second commit to improve a variable name. I would appreciate if you could double-check my work once again. Thanks.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: PHPBB3-15097 - Board statistics page should show PHP version

Post by DavidIQ » Fri Feb 17, 2017 9:29 pm

Your first commit is still wrong...
Image

User avatar
P_I
Registered User
Posts: 69
Joined: Fri Oct 31, 2014 4:56 am

Re: PHPBB3-15097 - Board statistics page should show PHP version

Post by P_I » Fri Feb 17, 2017 9:34 pm

Understood and still learning. I just don't understand how to edit and change it. When I click on the commit (https://github.com/phpbb/phpbb/pull/470 ... a85497605) I cannot find an edit/change button. Am I missing something?

Post Reply