[Template] overall_header_content_before

[Blitze]

Identifier: overall_header_content_before and overall_footer_content_after
Prosilver Location (if applicable): In overall_header.html after line 182, i.e. after the last line, and overall_footer.html before line 1 i.e. before the first line respectively
Subsilver Location (if applicable): In overall_header.html after line 240, i.e. after the last line, and overall_footer.html before line 1 i.e. before the first line respectively
Explanation: So extensions can add content that appears at the top of all pages after the header but before the main content and/or after the main content but before the footer.

Possible use cases for extensions include: advertisement, announcements, portals, etc

[Blitze]

Ticket: http://tracker.phpbb.com/browse/PHPBB3-12024
PR: https://github.com/phpbb/phpbb/pull/1878

[keith10456]

+1

[Pony99CA]

Identifier: overall_header_content_before and overall_footer_content_after
Explanation: So extensions can add content that appears at the top of all pages after the header but before the main content and/or after the main content but before the footer.

Then shouldn't these be called overall_header_after and overall_footer_before? The way you named them makes it sound like they come before the content of overall_header and after the content of overall_footer.

I understand that you mean "content" to be the main content of the page, but I think that just confuses things.

Steve

[Marc]

In fact, the naming is correct:

The identifier should be formatted as prosilver location file followed by a descriptor. For e.g.
overall_footer_copyright
If it is only in subsilver then the subsilver location should be used (as hooks don't have to be in both styles).

[Pony99CA]

In fact, the naming is correct:

The identifier should be formatted as prosilver location file followed by a descriptor. For e.g.
overall_footer_copyright
If it is only in subsilver then the subsilver location should be used (as hooks don't have to be in both styles).

That quote doesn't indicate whether either his or mine is right or wrong. I presume that "content" is a ProSilver descriptor in his case, not a location, but I still think that the original proposal is ambiguous (and I interpreted it opposite way until I read the description, hence my comment). Maybe "main_content" or "page_content" would make the event name clearer.

The idea itself is certainly reasonable, though.

Steve

[sajaki]

hi,

overall_header_content_before isn't defined in overal_footer.html.

is this a bug ?

[sajaki]

nevermind, i found overall_footer_content_after in the PR.