[RFC][PHPBB3-14596] 3.1.x - Installation denied if PHP >=7

[3Di]

Look at the commits I did here and compare them to yours. They are different and you didn't follow what I said needed to be done.

I am following all what posted here, my last commit though
https://github.com/phpbb/phpbb/pull/4297
reports the same error as per the picture I attached here..
https://area51.phpbb.com/phpBB/viewtopi ... 41#p290541

Could you please have a look at my new PR?
TIA

[RMcGirr83]

Look at the commits I did here and compare them to yours. They are different and you didn't follow what I said needed to be done.

I am following all what posted here, my last commit though
https://github.com/phpbb/phpbb/pull/4297
reports the same error as per the picture I attached here..
https://area51.phpbb.com/phpBB/viewtopi ... 41#p290541

Could you please have a look at my new PR?
TIA

See attached, that extra ticket thingy is probably messing it up

[3Di]

Ok, thx. I will try again then.

There should be something wrong here though
https://wiki.phpbb.com/Git#Commit_Messages

Should I remove that line from both commits?

[DavidIQ]

See attached, that extra ticket thingy is probably messing it up
Untitled.png

Actually he didn't have that line before and it was still failing which is why the line is there now.

What are you using to do your commits?

[3Di]

Correct.

I am writing directly on my fork at github.

[RMcGirr83]

Actually he didn't have that line before and it was still failing which is why the line is there now.

What are you using to do your commits?

Actually he didn't have PHPBB3-xxx in any of his prior commits which is why they were failing.

[3Di]

Actually he didn't have that line before and it was still failing which is why the line is there now.

What are you using to do your commits?

Actually he didn't have PHPBB3-xxx in any of his prior commits which is why they were failing.

I am getting more confused here.

https://github.com/phpbb/phpbb/pull/4296

https://github.com/phpbb/phpbb/pull/4295

https://github.com/phpbb/phpbb/pull/4294

and counting..

[RMcGirr83]

I am not sure why your commits are failing. I don't use github to make commits, I use smartgit and it works well.

https://github.com/phpbb/phpbb/pull/4298

[3Di]

I am not sure why your commits are failing. I don't use github to make commits, I use smartgit and it works well.

https://github.com/phpbb/phpbb/pull/4298

And yes, github is the issue as far I can see.

I forked now phpBB into my PC. I am used to use TortoiseGit and I will push a new PR later on tonight (UTC).

Thanks Rich.

I did 2/3 commits onto the QuickInstall's github in the past and went merged, on github.
Ofcourse the phpBB's github have some kind of tests more appropriated, I guess.

Well.. finger-crossed, uh?

[DavidIQ]

Actually he didn't have PHPBB3-xxx in any of his prior commits which is why they were failing.

He did. I've been following this on GitHub

So I guess the lesson from all this is: don't do commits directly from the GitHub interface as it does something funky to the line endings.