Enabling to translate "Re:" on others languages

[hrx]

Hello,

I've a question to developers of phpBB 3.1, why you didn't enable translating the text "Re:" on other language? Why it isn't in language/en/posting.php At present it is in phpBB3/posting.php

Code: Select all

if (($mode == 'reply' || $mode == 'quote') && !$submit && !$preview && !$refresh)
{
	$post_data['post_subject'] = ((strpos($post_data['post_subject'], 'Re: ') !== 0) ? 'Re: ' : '') . censor_text($post_data['post_subject']);
}

If translating this text into other language is possible I would ask for implementing such a possibility.

[Nicofuma]

IIRC it's because it's not possible to translate in the reader language because it's a part of the title (which can be removed/altered).

[hrx]

And so what that this can be deleted or altered? I'm not really understand what you mean in what you wrote, what it has common of enabling to the possibility translating it into any language?

[A_Jelly_Doughnut]

This was implemented long ago by shs, and then reverted. I couldn't find the commit right away, I'm 95% sure it was before we used github.

The problem isn't deleting it, it is what happens on a multi-language board.

For example:
Re: Enabling to translate "Re:" on others languages [English user replies]
От: Enabling to translate "Re:" on others languages [Russian user replies]
Ré: Enabling to translate "Re:" on others languages [French user replies]
От: Enabling to translate "Re:" on others languages [Russian user replies]
回复:Enabling to translate "Re:" on others languages [Chinese (simplified) user replies]
Re: Enabling to translate "Re:" on others languages [English user replies]

Etc.

This would be OK if you, presumably like most boards, only had one language pack installed. It was simply decided way back in history that leaving it in "Latin" was preferable to showing potentially dozens of prefixes.

EDIT: Actually, it's worse than this, as it was implemented long ago. Taking the same example I used earlier, what that implementation did was:
Re: Enabling to translate "Re:" on others languages [English user replies]
От: Re: Enabling to translate "Re:" on others languages [Russian user replies]
Ré: От: Re: Enabling to translate "Re:" on others languages [French user replies]
От: Ré: От: Re: Enabling to translate "Re:" on others languages [Russian user replies]
回复: От: Ré: От: Re: Enabling to translate "Re:" on others languages [Chinese (simplified) user replies]
Re: 回复: От: Ré: От: Re: Enabling to translate "Re:" on others languages [English user replies]

And pretty quickly you'd hit the 60 character post subject limit.
Relevant commits: https://github.com/phpbb/phpbb/commit/5 ... f12fa83049
https://github.com/phpbb/phpbb/commit/a ... 557ff36e2f

[pierredu]

The real best thing xould be to select in the ACP the prefix (or no prefix) and use it in the code to add something before if it not yet there.

[DavidIQ]

^ a setting for something as trivial as this??? No thanks. Plus specifying what the prefix would be doesn't really make a whole lot of sense since it's really a language string. If anything we should just go with not displaying the reply title if it matches the original title, which is the other topic referenced above.

[MattF]

As I mentioned in the other topic, you can't just turn this on or off at will. This is stored in the database with each and every title. The mst anyone could hope for is if they were just remove from phpBB all together by an update. However, IMO they are totally appropriate.

[hrx]

This would be OK if you, presumably like most boards, only had one language pack installed. It was simply decided way back in history that leaving it in "Latin" was preferable to showing potentially dozens of prefixes.

My board has only one language and therefore it surprised me why "Re:" can't translate on my language.

[DarkBeing]

Well, if in the current implemented form "Re:" can not be translated than maybe it should be solved in a different way. Maybe by splitting it from the title or enabling translation at least for boards who have only one other language installed.

[Nicofuma]

It can't be split from the title because it is a part a the title (you can edit it)