Commit messages and CRLF

[Louis7777]

A commit message looks like this (https://wiki.phpbb.com/Git):

Code: Select all

[branch you are working on] A short explanation of the change.

A more detailed explanation of which things exactly were changed and for
what reasons.

This can span multiple paragraphs for a bigger change. And
it should really make clear all the changes to anyone reading this commit
message without further context.

TICKET-ID

A commit message shouldn't contain any CRLF characters. Lines should end with LF.

While that is not a problem when I'm using my properly configured git client for Windows, I cannot figure out how to avoid it on the Github website.

It is convenient for me to create pull requests by visiting Github and clicking on the green button for "New pull request". But when I type my commit message I have no control over carriage returns, or do I?

Is it a protocol thing to always add CRLF by the end of a line? Or can I somehow configure my browser to use LF?

[callumacrae]

I'm pretty sure nobody has ever checked commit messages for the correct line endings

[Nicofuma]

Actually it is done by the commit inspector IIRC. And for the OP, sorry I don't think it is possible.

[Louis7777]

Actually it is done by the commit inspector IIRC. And for the OP, sorry I don't think it is possible.

So I assume that no one in the development team uses Github's web interface for creating pull requests - I'll have to stick with the git client, right?

[Nicofuma]

To edit the files and commit the changes? I guess yes

[callumacrae]

Actually it is done by the commit inspector IIRC. And for the OP, sorry I don't think it is possible.

So I assume that no one in the development team uses Github's web interface for creating pull requests - I'll have to stick with the git client, right?

Check out hub to create pull requests from the command line

[nickvergessen]

I create the PRs always via GitHubs website and I'm also in windows.

As long as the commit messages themselves are fine, nothing breaks from it.

[Louis7777]

I create the PRs always via GitHubs website and I'm also in windows.

What browser are you using?

So when you type your commit message over at GitHub and you press enter to leave a blank line, don't you cause any CRLF?