Feedback on 3.1.0-RC5

[roufneck]

Hi guys, not sure where to post this. If these are bugs or not that's for the experts to decide.

In .htaccess I need to add this line for the webprofiler extension to work.

Code: Select all

RewriteBase /

In .htaccess I need to add this line so an extension can change the home page without messing with index.php. If index.php isn't called explicitly, it will call app.php and it tries to find a route for /.

Code: Select all

DirectoryIndex app.php

In .htaccess I've added this for some improved security. Some are not needed, but personally I'd like to keep it all in one place.

Code: Select all

# Deny access
RedirectMatch 404 ^/(common.php|config.php)
RedirectMatch 404 ^/(bin|cache|config|ext|includes|language|phpbb|store|vendor)/

The 404 redirect match for ext is debatable. I'm not sure if template resources are called within an extension. But for sure all other files shouldn't be accessible. Since I don't have those asset files yet, I just restrict access to extensions for now.

Another option is to rename the current .htaccess file to .htaccess.dist and let the user create and manage it's own file. I think this would be a better option anyway.

In styles/prosilver/template/forumlist_body.html there is this:

Code: Select all

<!-- BEGIN forumrow -->
	<!-- IF (forumrow.S_IS_CAT and not forumrow.S_FIRST_ROW) or forumrow.S_NO_CAT  -->
			</ul>

			</div>
		</div>
	<!-- ENDIF -->

	<!-- EVENT forumlist_body_category_header_before -->
	<!-- IF forumrow.S_IS_CAT or forumrow.S_FIRST_ROW  or forumrow.S_NO_CAT  -->
		<div class="forabg">
			<div class="inner">
			<ul class="topiclist">
				<li class="header">
					<dl class="icon">
						<dt><div class="list-inner"><!-- IF forumrow.S_IS_CAT --><a href="{forumrow.U_VIEWFORUM}">{forumrow.FORUM_NAME}</a><!-- ELSE -->{L_FORUM}<!-- ENDIF --></div></dt>
						<dd class="topics">{L_TOPICS}</dd>
						<dd class="posts">{L_POSTS}</dd>
						<dd class="lastpost"><span>{L_LAST_POST}</span></dd>
					</dl>
				</li>
			</ul>
			<ul class="topiclist forums">
	<!-- ENDIF -->
	<!-- EVENT forumlist_body_category_header_after -->

Shouldn't the 2 events be inside the forum.S_IS_CAT check? Right now they are always called for every forumrow. I think they should only be called if the forumrow is a category:

Code: Select all

<!-- BEGIN forumrow -->
	<!-- IF (forumrow.S_IS_CAT and not forumrow.S_FIRST_ROW) or forumrow.S_NO_CAT  -->
			</ul>

			</div>
		</div>
	<!-- ENDIF -->

	<!-- IF forumrow.S_IS_CAT or forumrow.S_FIRST_ROW  or forumrow.S_NO_CAT  -->
	<!-- EVENT forumlist_body_category_header_before -->
		<div class="forabg">
			<div class="inner">
			<ul class="topiclist">
				<li class="header">
					<dl class="icon">
						<dt><div class="list-inner"><!-- IF forumrow.S_IS_CAT --><a href="{forumrow.U_VIEWFORUM}">{forumrow.FORUM_NAME}</a><!-- ELSE -->{L_FORUM}<!-- ENDIF --></div></dt>
						<dd class="topics">{L_TOPICS}</dd>
						<dd class="posts">{L_POSTS}</dd>
						<dd class="lastpost"><span>{L_LAST_POST}</span></dd>
					</dl>
				</li>
			</ul>
			<ul class="topiclist forums">
	<!-- EVENT forumlist_body_category_header_after -->		
	<!-- ENDIF -->

Thanx for all the work you guys have done for phpBB 3.1. I think it's a huge improvement and a joy to work with regarding extensions.

[MattF]

Hi guys, not sure where to post this. If these are bugs or not that's for the experts to decide.

In .htaccess I need to add this line for the webprofiler extension to work.

Code: Select all

RewriteBase /

This is an extension you are referring to, so this issue has to be discussed with extension's author.

In .htaccess I need to add this line so an extension can change the home page without messing with index.php. If index.php isn't called explicitly, it will call app.php and it tries to find a route for /.

Code: Select all

DirectoryIndex app.php

I don't see that as good change. It prevents having your board url be something like: http://www.myforum.com. because as you say, now you have to always use index.php. We already looked into trying to make extension routes available at the base of the url (myforum.com/extension) and we could not make it happen yet, because it requires at the very least a serious amount of core coding changes, and possibly some htaccess tweaks on top of that.

In .htaccess I've added this for some improved security. Some are not needed, but personally I'd like to keep it all in one place.

Code: Select all

# Deny access
RedirectMatch 404 ^/(common.php|config.php)
RedirectMatch 404 ^/(bin|cache|config|ext|includes|language|phpbb|store|vendor)/

The 404 redirect match for ext is debatable. I'm not sure if template resources are called within an extension. But for sure all other files shouldn't be accessible. Since I don't have those asset files yet, I just restrict access to extensions for now.

Another option is to rename the current .htaccess file to .htaccess.dist and let the user create and manage it's own file. I think this would be a better option anyway.

If you want to htaccess block access to those files, that is up to you. But phpBB is meant to be installed mostly in browser. We can't make the htaccess file a required file that users must edit, because the whole point for 3.1 is to eliminate editing, and we also can't assume people installing phpBB even know what an htaccess file is or how to edit one. Also, phpBB comes bundled as a 1-click install feature on many web hosting platforms, where editing the htaccess file would be prohibitive to that distribution model.

[Meis2M]

Hi

i sse this error in 3.1rc5

Code: Select all

[phpBB Debug] PHP Warning: in file [ROOT]/includes/acp/acp_update.php on line 63: sprintf() [function.sprintf]: Too few arguments

[DavidIQ]

Doing what? Updating?

[Meis2M]

no
when i go to "system" tab in acp i see this error in header. i did not nothing.

[nickvergessen]

This is mostly an error with your language package

[Meis2M]

thanks nick.

this was miss:
href="%1$s" title="%1$s" in language pack install.php

now it is fix.

[roufneck]

In .htaccess I need to add this line so an extension can change the home page without messing with index.php. If index.php isn't called explicitly, it will call app.php and it tries to find a route for /.

Code: Select all

DirectoryIndex app.php

I don't see that as good change. It prevents having your board url be something like: http://www.myforum.com. because as you say, now you have to always use index.php. We already looked into trying to make extension routes available at the base of the url (myforum.com/extension) and we could not make it happen yet, because it requires at the very least a serious amount of core coding changes, and possibly some htaccess tweaks on top of that.

It would be a lot easier if pages like index.php and viewforum.php would be written as symfony modules. This way you can easily overwrite the default routes. But I think I read that is something for the future.

Anyway, thanx for your reply.

[Nicofuma]

It would be a lot easier if pages like index.php and viewforum.php would be written as symfony modules. This way you can easily overwrite the default routes. But I think I read that is something for the future.

Anyway, thanx for your reply.

We will. But it requires a lot of work and it's not our highest priority, but if someone wants to contribute and send a PR for that he is welcome

About the web profiler extension, can you report your bug here with more details please?

[mrgtb]

Something I wanted to touch on about the ProSilver style. I was reading somebody mention on another forum tonight why it uses an 850px max-width style and have been thinking same thing myself.

How comes you do that, rather than using gutter left/right margin spacing (keeping forum fluid). So prosilver, no matter what size resolution is used by people would fit the screen having same margin space left and right showing background, so the forum more or less fills full screen. As right now doing it the way you do, having that max-width used, anyone using a high res screen is going to have a small forum in middle with load of background showing left and right. It doesn't really suit all screen resolution sizes - not I think like using margin spacing would left and right instead and keeping it a fluid style