[RFC] Define max-width for prosilver

[Pete77s]

I agree, An option in the ACP is unnecessary. Tried testing it out in common.css myself and it breaks the responsiveness of the theme.
Could someone shed some light on the the best way to set max-width in prosilver for testing purposes?


Actually light border and shadow wouldn't be so bad +1 to that. Anything but image corners

[FloFlo91]

I agree, An option in the ACP is unnecessary. Tried testing it out in common.css myself and it breaks the responsiveness of the theme.
Could someone shed some light on the the best way to set max-width in prosilver for testing purposes?

Actually light border and shadow wouldn't be so bad +1 to that. Anything but image corners

Just add those two CSS rules on the #wrap :

Code: Select all

max-width: 1152px;
margin: 0 auto;

It's fine to me.

[PayBas]

Could someone shed some light on the the best way to set max-width in prosilver for testing purposes?

Or just pull this: https://github.com/phpbb/phpbb/pull/2533/files

[Pete77s]

Thanks PayBas

[Sumanai]

PayBas, Why not a variant from this post?
In my opinion, it looks better.

[PayBas]

PayBas, Why not a variant from this post?
In my opinion, it looks better.

Because everyone wants something different and I don't feel like changing it 10 times.

I'll wait until some of the devs make a clear preference, and change it then.

[FloFlo91]

For me, PaysBas did the best version, it's the best compromise In my opinion.

You did a good job.

[Master_Cylinder]

I want mine as wide as possible, with as little padding as possible.

[Louis7777]

I want mine as wide as possible, with as little padding as possible.

Would you like some syrup with your pudding, sir?

That's how I prefer it too, but personally I'm fine if you guys set a max-width. I usually have a phpbb portal or some cms as the homepage and I set a max-width for that, while I keep the forums as wide as possible.

Also, I don't think there's anything wrong with the way it is now.

[Master_Cylinder]

I just don't have a desire to make it small/ugly like phpbb.com does.