[Template] posting_editor_subject_after

These requests for events in core phpBB have been merged into 3.1/Ascraeus and will be available with the next release.
Post Reply
User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

[Template] posting_editor_subject_after

Post by imkingdavid »

Identifier: posting_editor_subject_after
Prosilver Location (if applicable): In posting_editor.html, around line 100 (i.e. above <!-- INCLUDE posting_buttons.html -->, aka under the code block shown below)
Subsilver Location (if applicable): In posting_body.html, around line 171 (i.e. between the <tr> for the subject and for the message body

Goes after this prosilver code:

Code: Select all

	<!-- IF S_POST_ACTION or S_PRIVMSGS or S_EDIT_DRAFT -->
	<dl style="clear: left;">
		<dt><label for="subject">{L_SUBJECT}{L_COLON}</label></dt>
		<dd><input type="text" name="subject" id="subject" size="45" maxlength="<!-- IF S_NEW_MESSAGE -->120<!-- ELSE -->124<!-- ENDIF -->" tabindex="2" value="{SUBJECT}{DRAFT_SUBJECT}" class="inputbox autowidth" /></dd>
	</dl>
	<!-- IF CAPTCHA_TEMPLATE and S_CONFIRM_CODE -->
		<!-- DEFINE $CAPTCHA_TAB_INDEX = 3 -->
		<!-- INCLUDE {CAPTCHA_TEMPLATE} -->
	<!-- ENDIF -->
	<!-- ENDIF -->
Explanation: My [pre]fixed Topic Prefixes extension needs to have a way for users to select one or more prefixes for appending to the topic title. Between the subject text box and the message box seems like the best spot.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.
User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [Template] posting_add_options

Post by imkingdavid »

On second thought, I'm wondering if this should be renamed, since the stuff under the submit buttons is in a tab called "Options", so this might get confused with that.

How's about... posting_add_fields?
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.
User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [Template] posting_add_options

Post by imkingdavid »

On third thought, this should be called "posting_editor_subject_after" and is meant to be used to add fields after the subject field.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.
User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [Template] posting_editor_subject_after

Post by MichaelC »

+1 to your last suggestion except we use append and prepend as opposed to before/after.

PR?
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.
User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [Template] posting_editor_subject_after

Post by imkingdavid »

MichaelC wrote:+1 to your last suggestion except we use append and prepend as opposed to before/after.

PR?
We use append/prepend in some cases and before/after in other cases. after makes sense in this case because I'm not appending it to the subject field; it is a field being added after the subject field.

EDIT: PR from 3 days ago: https://github.com/phpbb/phpbb/pull/1821
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.
Post Reply