[RFC] Add foreign keys to phpBB3.1 to make it faster

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
brunoais
Registered User
Posts: 964
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] Add foreign keys to phpBB3.1 to make it faster

Post by brunoais »

I can do that no prob. The issue is that I don't have a big board to test it on.
If someone can get me "junk" ( DB dump or a traffic generator) to fill my local phpBB forum so that it becomes properly/enough filled I can do benchmark tests to see how much difference I can make by adding foreign keys.
The main reason here is the clams of lack of speed of the queries to apply the idea topic I mentioned.
Anyway, It only works for when there are JOIN's, otherwise, it's just another hassle for the DB :).

sajaki
Registered User
Posts: 86
Joined: Mon Jun 21, 2010 8:28 pm

Re: [RFC] Add foreign keys to phpBB3.1 to make it faster

Post by sajaki »

code reader wrote:
DavidIQ wrote:+1 but I'm not sure 3.1 should be the target. This is much bigger/complex than just defining a few foreign keys.
??????
as far as i understand, this RFC is about one thing, and one thing only: adding some foreign key indexes. how is it "much bigger/complex than just defining a few foreign keys"? what else is there in this RFC?
The Dbal currently doesn't allow adding tables with foreign keys, nor does UMIL. Supporting FK would mean building all that into the Dbal for all supported DMBS. Not likely for 3.1.

User avatar
brunoais
Registered User
Posts: 964
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] Add foreign keys to phpBB3.1 to make it faster

Post by brunoais »

Bummer...
I didn't know about that one...

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1904
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Add foreign keys to phpBB3.1 to make it faster

Post by DavidIQ »

brunoais wrote:I can do that no prob. The issue is that I don't have a big board to test it on.
If someone can get me "junk" ( DB dump or a traffic generator) to fill my local phpBB forum so that it becomes properly/enough filled I can do benchmark tests to see how much difference I can make by adding foreign keys.
The main reason here is the clams of lack of speed of the queries to apply the idea topic I mentioned.
Anyway, It only works for when there are JOIN's, otherwise, it's just another hassle for the DB :).
Should be able to use QI for that.
Image

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Add foreign keys to phpBB3.1 to make it faster

Post by imkingdavid »

DavidIQ wrote:
brunoais wrote:I can do that no prob. The issue is that I don't have a big board to test it on.
If someone can get me "junk" ( DB dump or a traffic generator) to fill my local phpBB forum so that it becomes properly/enough filled I can do benchmark tests to see how much difference I can make by adding foreign keys.
The main reason here is the clams of lack of speed of the queries to apply the idea topic I mentioned.
Anyway, It only works for when there are JOIN's, otherwise, it's just another hassle for the DB :).
Should be able to use QI for that.
Has QI been modified to work on 3.1? Last I heard, it didn't but I don't know if that got fixed at Montreal.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1904
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Add foreign keys to phpBB3.1 to make it faster

Post by DavidIQ »

Hmmm...that might have been the plan but since Jari couldn't make it it might not have been done. At this point it might be beneficial to have it ready and available already so I'll follow up with him.
Image

User avatar
brunoais
Registered User
Posts: 964
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] Add foreign keys to phpBB3.1 to make it faster

Post by brunoais »

tracker ticket# please.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1904
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Add foreign keys to phpBB3.1 to make it faster

Post by DavidIQ »

Ticket # for what? QI? That is a tool the MOD Team develops and doesn't belong in the tracker. ;)
Image

User avatar
brunoais
Registered User
Posts: 964
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] Add foreign keys to phpBB3.1 to make it faster

Post by brunoais »

Oh! ok.

User avatar
tumba25
Registered User
Posts: 14
Joined: Sun Feb 01, 2009 10:13 pm
Location: Kokkola, Finland.
Contact:

Re: [RFC] Add foreign keys to phpBB3.1 to make it faster

Post by tumba25 »

imkingdavid wrote:Has QI been modified to work on 3.1? Last I heard, it didn't but I don't know if that got fixed at Montreal.
The support for 3.1 has not been completed yet. I'll do that as soon as I get some free time.
Image

Need a mod created/installed, other custom-coded solution or a server admin? https://tumba25.net

Post Reply