I can do that no prob. The issue is that I don't have a big board to test it on.
If someone can get me "junk" ( DB dump or a traffic generator) to fill my local phpBB forum so that it becomes properly/enough filled I can do benchmark tests to see how much difference I can make by adding foreign keys.
The main reason here is the clams of lack of speed of the queries to apply the idea topic I mentioned.
Anyway, It only works for when there are JOIN's, otherwise, it's just another hassle for the DB .
[RFC] Add foreign keys to phpBB3.1 to make it faster
Re: [RFC] Add foreign keys to phpBB3.1 to make it faster
The Dbal currently doesn't allow adding tables with foreign keys, nor does UMIL. Supporting FK would mean building all that into the Dbal for all supported DMBS. Not likely for 3.1.code reader wrote:??????DavidIQ wrote:+1 but I'm not sure 3.1 should be the target. This is much bigger/complex than just defining a few foreign keys.
as far as i understand, this RFC is about one thing, and one thing only: adding some foreign key indexes. how is it "much bigger/complex than just defining a few foreign keys"? what else is there in this RFC?
Re: [RFC] Add foreign keys to phpBB3.1 to make it faster
Bummer...
I didn't know about that one...
I didn't know about that one...
- DavidIQ
- Customisations Team Leader
- Posts: 1904
- Joined: Thu Mar 02, 2006 4:29 pm
- Location: Earth
- Contact:
Re: [RFC] Add foreign keys to phpBB3.1 to make it faster
Should be able to use QI for that.brunoais wrote:I can do that no prob. The issue is that I don't have a big board to test it on.
If someone can get me "junk" ( DB dump or a traffic generator) to fill my local phpBB forum so that it becomes properly/enough filled I can do benchmark tests to see how much difference I can make by adding foreign keys.
The main reason here is the clams of lack of speed of the queries to apply the idea topic I mentioned.
Anyway, It only works for when there are JOIN's, otherwise, it's just another hassle for the DB .
- imkingdavid
- Registered User
- Posts: 1050
- Joined: Thu Jul 30, 2009 12:06 pm
Re: [RFC] Add foreign keys to phpBB3.1 to make it faster
Has QI been modified to work on 3.1? Last I heard, it didn't but I don't know if that got fixed at Montreal.DavidIQ wrote:Should be able to use QI for that.brunoais wrote:I can do that no prob. The issue is that I don't have a big board to test it on.
If someone can get me "junk" ( DB dump or a traffic generator) to fill my local phpBB forum so that it becomes properly/enough filled I can do benchmark tests to see how much difference I can make by adding foreign keys.
The main reason here is the clams of lack of speed of the queries to apply the idea topic I mentioned.
Anyway, It only works for when there are JOIN's, otherwise, it's just another hassle for the DB .
- DavidIQ
- Customisations Team Leader
- Posts: 1904
- Joined: Thu Mar 02, 2006 4:29 pm
- Location: Earth
- Contact:
Re: [RFC] Add foreign keys to phpBB3.1 to make it faster
Hmmm...that might have been the plan but since Jari couldn't make it it might not have been done. At this point it might be beneficial to have it ready and available already so I'll follow up with him.
Re: [RFC] Add foreign keys to phpBB3.1 to make it faster
tracker ticket# please.
- DavidIQ
- Customisations Team Leader
- Posts: 1904
- Joined: Thu Mar 02, 2006 4:29 pm
- Location: Earth
- Contact:
Re: [RFC] Add foreign keys to phpBB3.1 to make it faster
Ticket # for what? QI? That is a tool the MOD Team develops and doesn't belong in the tracker.
- tumba25
- Registered User
- Posts: 14
- Joined: Sun Feb 01, 2009 10:13 pm
- Location: Kokkola, Finland.
- Contact:
Re: [RFC] Add foreign keys to phpBB3.1 to make it faster
The support for 3.1 has not been completed yet. I'll do that as soon as I get some free time.imkingdavid wrote:Has QI been modified to work on 3.1? Last I heard, it didn't but I don't know if that got fixed at Montreal.