One of the annoying aspects of github is that only the pull request's author can add commits to the pull request. This can be fixed by adding collaborators but 1) nobody does that with a singular exception that I know of and 2) it is still too much work.
Therefore, I created a p-push organization (https://github.com/p-push). I will add anyone requesting access to the phpbb team. From then on, you can create branches under p-push instead of, or in addition to, creating branches in your own repository, and send pull requests from p-push's repository. Any of the collaborators will be able to add commits to any open pull request.
You can reply here if you would like access or mail me at [email protected].
Git push account - for shared work
-
asperous
- Google Summer of Code Student
- Posts: 21
- Joined: Mon Apr 22, 2013 3:26 pm
- Location: Tigard, Or
- Contact:
Re: Git push account - for shared work
This looks great, I am interested to see how well it works.
I always assumed you could add to pull requests by filing a pull request on the contributor's feature branch, and when merged it would show up, do you know if it works this way?
I always assumed you could add to pull requests by filing a pull request on the contributor's feature branch, and when merged it would show up, do you know if it works this way?
-
dhruv.goel92
- Registered User
- Posts: 22
- Joined: Sun Mar 18, 2012 9:30 pm
Re: Git push account - for shared work
This can indeed be very helpful.Oleg wrote: Therefore, I created a p-push organization (https://github.com/p-push). I will add anyone requesting access to the phpbb team. From then on, you can create branches under p-push instead of, or in addition to, creating branches in your own repository, and send pull requests from p-push's repository. Any of the collaborators will be able to add commits to any open pull request.
-
imkingdavid
- Registered User
- Posts: 1050
- Joined: Thu Jul 30, 2009 12:06 pm
Re: Git push account - for shared work
That's a good idea for patches that will likely require a lot of collaboration. If you don't mind adding me as a collaborator, I may consider moving my branch for this over to it.
-
callumacrae
- Former Team Member
- Posts: 1046
- Joined: Tue Apr 27, 2010 9:37 am
- Location: England
- Contact:
Re: Git push account - for shared work
Yeah, that's what we've done in the past: https://github.com/igorw/phpbb3/pull/9asperous wrote:This looks great, I am interested to see how well it works.
I always assumed you could add to pull requests by filing a pull request on the contributor's feature branch, and when merged it would show up, do you know if it works this way?
Re: Git push account - for shared work
Just as an idea form another open source project and there chat:
this might also help to collaborate{20:38:43} [@DGandalf] kylef: btw, how did you attach commits to someone else's pull request (who even doesn't have any commit there)?
{20:39:37} [kylef] hub pull-request -i 138
{20:39:53} [kylef] there is no UI for it, but it's in the API
{20:41:15} [@DGandalf] "hub"?
{20:42:15} [kylef] https://github.com/defunkt/hub
Re: Git push account - for shared work
Only possible for repository collaborators afaik though?