Unapproved post status

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The current feature release of phpBB 3 is 3.3/Proteus.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.3.x. If you need support for phpBB 3.3.x please visit the 3.3.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Post Reply
leschek
Registered User
Posts: 164
Joined: Tue Aug 28, 2012 1:30 pm

Unapproved post status

Post by leschek »

It seems that users, who write on forum, where moderators approving posts, doesn't know what happens with their posts, which is frustrating. I would like to ask, if would be possible to add to user panel tab, where user could see what is status of his/her unapproved posts - waiting for approval, deleted + optional reason.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: Unapproved post status

Post by nickvergessen »

There is an option to notify the user via Email about his post being (un)approved by the moderator.
However, if the moderator does not like that, it is possible to not send the email.

I somewhat agree here thou. But this would have to wait for Soft-delete feature to be merged, to avoid more conflicts.
Member of the Development-TeamNo Support via PM

User avatar
brunoais
Registered User
Posts: 964
Joined: Fri Dec 18, 2009 3:55 pm

Re: Unapproved post status

Post by brunoais »

The idea would be that the post wouldn't disappear but instead it would be shown in the list like it is shown for the moderators (ofc, without the moderator's options) and with a different color like it happens with reported posts (with a different color, anyway ;) ).

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: Unapproved post status

Post by nickvergessen »

brunoais wrote:The idea would be that the post wouldn't disappear but instead it would be shown in the list like it is shown for the moderators (ofc, without the moderator's options) and with a different color like it happens with reported posts (with a different color, anyway ;) ).
Well that's one idea, the idea from the original post is another one, which is way easier to implement ;)
Member of the Development-TeamNo Support via PM

User avatar
brunoais
Registered User
Posts: 964
Joined: Fri Dec 18, 2009 3:55 pm

Re: Unapproved post status

Post by brunoais »

If you go through the "easy" it's the OP's. Mine is more into usability. I think mine's more usable and his' more easy to implement.

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: Unapproved post status

Post by Pony99CA »

brunoais wrote:The idea would be that the post wouldn't disappear but instead it would be shown in the list like it is shown for the moderators (ofc, without the moderator's options) and with a different color like it happens with reported posts (with a different color, anyway ;) ).
I agree. I don't see why users shouldn't be able to see (and even edit or delete, if they have those permissions) their own unapproved posts (or posts that they soft deleted themselves for that matter).
nickvergessen wrote:
brunoais wrote:The idea would be that the post wouldn't disappear but instead it would be shown in the list like it is shown for the moderators (ofc, without the moderator's options) and with a different color like it happens with reported posts (with a different color, anyway ;) ).
Well that's one idea, the idea from the original post is another one, which is way easier to implement ;)
How is that easier? You'd need a whole new user page and possibly a new permission. With Brunoais'/my suggestion, you just piggyback off of the existing flagging of unapproved posts, but clicking the "?" icon wouldn't do anything (there would be no link to the MCP). There's a minor change to the SQL query for posts/topics and a change to whether or not the icon links to the MCP. I presume that there would also be a change the SQL used for searching.

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

User avatar
Marc
Development Team Leader
Development Team Leader
Posts: 195
Joined: Thu Sep 09, 2010 11:36 am
Location: Munich, Germany

Re: Unapproved post status

Post by Marc »

A while back I added something like that to the tracker: http://tracker.phpbb.com/browse/PHPBB3-9837

I haven't had much enthusiasm to work on this; mostly because the posted implementation is kind of hackish and possibly causes issues as Oleg pointed out in the tracker.

Also it'll need some changes after or if Soft delete gets merged in the develop branch.

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: Unapproved post status

Post by Pony99CA »

Marc wrote:A while back I added something like that to the tracker: http://tracker.phpbb.com/browse/PHPBB3-9837

I haven't had much enthusiasm to work on this; mostly because the posted implementation is kind of hackish and possibly causes issues as Oleg pointed out in the tracker.
The UI was basically what I was thinking of, too. I don't know about the implementation, but I hope that you'll try it again. I think that this would be very useful.
Marc wrote:Also it'll need some changes after or if Soft delete gets merged in the develop branch.
According to the last comment in the ticket, Soft Delete has already been merged:
Joas Schilling added a comment - 09/Nov/12 2:37 PM
Needs to be redone from scratch after softdelete was merged.
The Soft Delete RFC isn't tagged as Merged, though. :?

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: Unapproved post status

Post by nickvergessen »

Pony99CA wrote:The Soft Delete RFC isn't tagged as Merged, though.
Yes, the problem is, it is currently blocked because it's waiting for migrations:
viewtopic.php?p=247621#p247621
oddfish wrote:a database_update.php error.
Works OK updating a vanilla install but where topic_replies does not exist then this error is thrown:

Code: Select all

Fatal error: SQL ERROR [ mysqli ]
Unknown column 'topic_replies' in 'field list' [1054]
SQL
SELECT topic_id, topic_visibility, (topic_replies + 1) AS topic_posts_approved, topic_last_post_id, topic_last_post_subject, topic_last_post_time, topic_last_poster_id, topic_last_poster_name, topic_last_poster_colour FROM phpbb_topics WHERE forum_id = 0 AND topic_type = 3 in /home/me/public_html/soft/includes/db/dbal.php on line 809
Member of the Development-TeamNo Support via PM

leschek
Registered User
Posts: 164
Joined: Tue Aug 28, 2012 1:30 pm

Re: Unapproved post status

Post by leschek »

Thank you for discussing this. What do I have to do now, when I would like to see it in some future release of phpBB. I understand that I should write RFC. Or is possible to move the whole topic there?

Post Reply