[RFC|Merged] Make ext/ directory
Re: [RFC] Make ext/ directory
Making the ext directory during package building sounds reasonable.
- bantu
- 3.0 Release Manager
- Posts: 557
- Joined: Thu Sep 07, 2006 11:22 am
- Location: Karlsruhe, Germany
- Contact:
Re: [RFC] Make ext/ directory
On the other side, I would rather not assume that everyone who downloaded phpBB via git has a working build environment and tools installed. It has been suggested to me that composer can be used to generate required folders instead. Right now, composer has to run on git checkouts, so this does not add another requirement.Oleg wrote:Making the ext directory during package building sounds reasonable.
Re: [RFC] Make ext/ directory
+1bantu wrote:On the other side, I would rather not assume that everyone who downloaded phpBB via git has a working build environment and tools installed. It has been suggested to me that composer can be used to generate required folders instead. Right now, composer has to run on git checkouts, so this does not add another requirement.Oleg wrote:Making the ext directory during package building sounds reasonable.
http://getcomposer.org/doc/articles/scripts.md
Formerly known as Unknown Bliss
No unsolicited PMs please except for quotes.psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
Re: [RFC] Make ext/ directory
If composer is not required to build packages then package building should still create the directory.
Creating it via composer seems to be ok to me.
Creating it via composer seems to be ok to me.
- imkingdavid
- Registered User
- Posts: 1050
- Joined: Thu Jul 30, 2009 12:06 pm
Re: [RFC] Make ext/ directory
PR using composer to create the ext/ directory: https://github.com/phpbb/phpbb3/pull/1032
Make sure your composer.phar is up to date, then remove the vendor/ directory and composer.lock file (if present) before running
Make sure your composer.phar is up to date, then remove the vendor/ directory and composer.lock file (if present) before running
php ../composer.phar install --dev
from the phpbb3/phpBB/ directory.- bantu
- 3.0 Release Manager
- Posts: 557
- Joined: Thu Sep 07, 2006 11:22 am
- Location: Karlsruhe, Germany
- Contact:
Re: [RFC] Make ext/ directory
phpBB does not work without its dependencies. Composer installs dependencies, so composer is required for building packages.Oleg wrote:If composer is not required to build packages then package building should still create the directory.
This should be extended to all the other folders such as cache for consistency. The .htacces and index.html file should in my opinion be created by the build script. We can assume that people using phpBB via git know how to secure their webserver.imkingdavid wrote:PR using composer to create the ext/ directory: https://github.com/phpbb/phpbb3/pull/1032
Re: [RFC] Make ext/ directory
You should update the composer.phar in the repo with your PR?imkingdavid wrote:PR using composer to create the ext/ directory: https://github.com/phpbb/phpbb3/pull/1032
Make sure your composer.phar is up to date, then remove the vendor/ directory and composer.lock file (if present) before runningphp ../composer.phar install --dev
from the phpbb3/phpBB/ directory.
Formerly known as Unknown Bliss
No unsolicited PMs please except for quotes.psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
Re: [RFC] Make ext/ directory
phpbb does not work without its dependencies but it does work without composer.bantu wrote:phpBB does not work without its dependencies. Composer installs dependencies, so composer is required for building packages.Oleg wrote:If composer is not required to build packages then package building should still create the directory.
The question was whether build process invoked composer and failed if composer was missing.
- bantu
- 3.0 Release Manager
- Posts: 557
- Joined: Thu Sep 07, 2006 11:22 am
- Location: Karlsruhe, Germany
- Contact:
Re: [RFC] Make ext/ directory
Yes, it calls composer and should fail if it's missing. https://github.com/phpbb/phpbb3/blob/de ... ld.xml#L15Oleg wrote:The question was whether build process invoked composer and failed if composer was missing.