[RFC|Merged] notification box
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] notification box
Anything can add new notification types. Right now it's just a matter of dropping a file in the includes/notifications/types/ directory. After more important stuff is finished, I'd like to figure out how to allow extensions to keep the notification files in their own ext directory and load them.
Re: [RFC] notification box
See https://github.com/phpbb/phpbb3/pull/995/files#diff-12 as an example on howEXreaction wrote:Anything can add new notification types. Right now it's just a matter of dropping a file in the includes/notifications/types/ directory. After more important stuff is finished, I'd like to figure out how to allow extensions to keep the notification files in their own ext directory and load them.
<extpath>/config/routing.yml
files are included for the controller.Formerly known as Unknown Bliss
No unsolicited PMs please except for quotes.psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
- imkingdavid
- Registered User
- Posts: 1050
- Joined: Thu Jul 30, 2009 12:06 pm
Re: [RFC] notification box
Yes, you can use the phpbb_extension_finder object to locate files that follow a consistent location and/or naming convention within extensions. The example Michael linked to is probably not the best because I added some extra stuff to it, such as the dirname call to get the directory names for each of the files it loaded, rather than the file paths themselves (due to the inner workings of Symfony). But I guess it should give you the basic idea.Unknown Bliss wrote:See https://github.com/phpbb/phpbb3/pull/995/files#diff-12 as an example on howEXreaction wrote:Anything can add new notification types. Right now it's just a matter of dropping a file in the includes/notifications/types/ directory. After more important stuff is finished, I'd like to figure out how to allow extensions to keep the notification files in their own ext directory and load them.<extpath>/config/routing.yml
files are included for the controller.
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] notification box
This all should be fixed now.oddfish wrote:Yes, latest from this morning - grabbed all changes again and compared and yeah, latest.EXreaction wrote:Did you try the latest code from this morning? That username color issue should have been fixed.
I would not expect the content of the notification to change when editing another user's post which had nothing to do with the initial notification. Perhaps the issue is in that.
As Admin, I subscribed to a forum ...Ends up changing the username colour to default notification font colour.
- Create a new topic as a second user.
- Reply as a third user
- As Admin, edit the first post by second user
That is where the username, subject and time change in the notification with no username colour either.
- Edit the 2nd post by the third user
Hope that helps.
Sorry, should have posted the full error.EXreaction wrote:You get an error that post_subject is not defined?x3 of that line when editing, x1 when posting.Code: Select all
[phpBB Debug] PHP Notice: in file [ROOT]/includes/notifications/type/post.php on line 216: Undefined index: post_subject
Re: [RFC] notification box
Regarding styling... Have you seen how Ebay does it with their Notifications in their menubar? You just hover the mouse and it appears in a drop-down. Something like that would be nice, as long as it is properly themed to look like part of Prosilver.
Has an irascible disposition.
- oddfish
- Registered User
- Posts: 110
- Joined: Tue Mar 27, 2007 5:53 am
- Location: on my way home
- Contact:
Re: [RFC] notification box
Yes.EXreaction wrote:This all should be fixed now.oddfish wrote: ...
A thought; when a post is edited, the order of notifications change. How do you know if the change in order reflects a new reply or an edited post? In this case,
editing shows the current notification :
... replied to the topic "Swimmingly effective" you have bookmarked ...
Perhaps when edited :
... edited their reply to the topic "Swimmingly effective" you have bookmarked ...
I know the post number is shown when hovering and that the number of notifications does not change (and that is great for the
but this is "Notification" and in my opinion the detail should do any guess work.
.. quoted it an edit?
/type/quote.php Line 159
// If the user has read the topic/post already, and the user is newly quoted it an edit,
cheers,
oddfish.
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] notification box
I'm working on the UCP and here is what it looks like now, any input would be appreciated.
Ignore the ones in caps.
Ignore the ones in caps.
- Attachments
-
- 1 yourdomain.com User Control Panel UCP_NOTIFICATIONS.png
- (84.37 KiB) Downloaded 2291 times
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] notification box
I'm not sure I like the idea of using hover to automatically display it, at least not in the position it is in with prosilver.VSE+ wrote:Regarding styling... Have you seen how Ebay does it with their Notifications in their menubar? You just hover the mouse and it appears in a drop-down. Something like that would be nice, as long as it is properly themed to look like part of Prosilver.
The order changes? In the future, someone should not be notified multiple times by one thing (e.g. someone replies and quotes you). I've not gotten to this functionality yet.oddfish wrote:A thought; when a post is edited, the order of notifications change. How do you know if the change in order reflects a new reply or an edited post? In this case,
editing shows the current notification :... replied to the topic "Swimmingly effective" you have bookmarked ...
Perhaps when edited :... edited their reply to the topic "Swimmingly effective" you have bookmarked ...
.
It couldn't say "edited their reply" because that would be an entirely different type of notification.
I'm not sure what you mean?oddfish wrote:I know the post number is shown when hovering and that the number of notifications does not change (and that is great for thememoristsgifted)
but this is "Notification" and in my opinion the detail should do any guess work.
It's a comment I've placed so I remember to look into that some more in the future. The comment is longer, but it's basically about the complexity of notifications when a user edits a post and adds/removes quotes of different users (mainly the read status of the notification).oddfish wrote:.. quoted it an edit?
/type/quote.php Line 159// If the user has read the topic/post already, and the user is newly quoted it an edit,
- oddfish
- Registered User
- Posts: 110
- Joined: Tue Mar 27, 2007 5:53 am
- Location: on my way home
- Contact:
Re: [RFC] notification box
A couple of things.
Add {L_TITLE} and {L_NOTIFICATIONS_EXPLAIN} into ucp_notifications.html.
Singular [ 1 Notification ] done as per (1 new message).
My previous thoughts. Only tested as Admin :
Line 159 in quote.php says
Add {L_TITLE} and {L_NOTIFICATIONS_EXPLAIN} into ucp_notifications.html.
Singular [ 1 Notification ] done as per (1 new message).
My previous thoughts. Only tested as Admin :
- Subscribe to forum as Admin.
- User1 posts a new topic.
- User2 posts a new topic.
- User1 replies to User2 topic.
- User2 replies to User1 topic.
- Edit User2 reply to User1 topic as Admin.
Line 159 in quote.php says
..and the user is newly quoted it an edit..
. Should it not read ..and the user is newly quoted in an edit..
?Re: [RFC] notification box
I agree. This can be a problem if you're browsing it from a touch screen.EXreaction wrote:VSE+ wrote:Regarding styling... Have you seen how Ebay does it with their Notifications in their menubar? You just hover the mouse and it appears in a drop-down. Something like that would be nice, as long as it is properly themed to look like part of Prosilver.
Slightly better English than it was in 2005, still improving