I redesigned the output a bit to fit better with prosilver. Still needs some work (mark unread should be an icon and use AJAX).
I also believe I've fixed those issues.
[RFC|Merged] notification box
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
-
- Registered User
- Posts: 523
- Joined: Sat Apr 22, 2006 10:29 pm
- Contact:
Re: [RFC] notification box
Thanks for working on this... I'm certain the community will love it
- Jessica.
- Registered User
- Posts: 144
- Joined: Wed Feb 09, 2011 8:17 pm
- Location: Pennsylvania, USA
- Contact:
Re: [RFC] notification box
how about notification of a request to join a group? (https://www.phpbb.com/customise/db/mod/ ... er_needed/)
- oddfish
- Registered User
- Posts: 110
- Joined: Tue Mar 27, 2007 5:53 am
- Location: on my way home
- Contact:
Re: [RFC] notification box
The issue of defined group colour goes a little deeper. This shows a notification when a new topic was posted in a forum resulting from subscribing to that forum.
Editing a post (as admin) within that subscribed topic? .. magic. Notice here the username changed (top entry along with lost group colour) and with it, subject and time. Admin post edited (own post), does not lose the group colour with the changes.
On that, the post_subject is undefined in type/post.php when posting or editing (l216).
p.s. I think • does separate the look consistently (although personal opinion can blur concepts)
Editing a post (as admin) within that subscribed topic? .. magic. Notice here the username changed (top entry along with lost group colour) and with it, subject and time. Admin post edited (own post), does not lose the group colour with the changes.
On that, the post_subject is undefined in type/post.php when posting or editing (l216).
p.s. I think • does separate the look consistently (although personal opinion can blur concepts)
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] notification box
Did you try the latest code from this morning? That username color issue should have been fixed.oddfish wrote:The issue of defined group colour goes a little deeper. This shows a notification when a new topic was posted in a forum resulting from subscribing to that forum.
Editing a post (as admin) within that subscribed topic? .. magic. Notice here the username changed (top entry along with lost group colour) and with it, subject and time. Admin post edited (own post), does not lose the group colour with the changes.
On that, the post_subject is undefined in type/post.php when posting or editing (l216).
p.s. I think • does separate the look consistently (although personal opinion can blur concepts)
You get an error that post_subject is not defined?
What happens currently when a user requests to join a group? Is the group leader notified or how does it work?Jessica. wrote:how about notification of a request to join a group? (https://www.phpbb.com/customise/db/mod/ ... er_needed/)
Re: [RFC] notification box
+1Jessica. wrote:how about notification of a request to join a group? (https://www.phpbb.com/customise/db/mod/ ... er_needed/)
Also I think a notification of an event : you have joined/left group , would be very useful.
- Pony99CA
- Registered User
- Posts: 986
- Joined: Sun Feb 08, 2009 2:35 am
- Location: Hollister, CA
- Contact:
Re: [RFC] notification box
I don't think that you need to be notified when you join or leave a group; you should probably be notified when you are added to or deleted from a group by somebody else.Avdon wrote:+1Jessica. wrote:how about notification of a request to join a group? (https://www.phpbb.com/customise/db/mod/ ... er_needed/)
Also I think a notification of an event : you have joined/left group , would be very useful.
In addition, would it be useful to notify other group members when somebody is added or removed? (Obviously not for most of the pre-defined groups, although Admins and Global Moderators might be an exception.)
However, these might be new features that require their own RFC. I presume this RFC is just for handling existing notifications, not designing new ones (although notifying Moderators of posts in the queue might be new).
Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.
- oddfish
- Registered User
- Posts: 110
- Joined: Tue Mar 27, 2007 5:53 am
- Location: on my way home
- Contact:
Re: [RFC] notification box
Yes, latest from this morning - grabbed all changes again and compared and yeah, latest.EXreaction wrote:Did you try the latest code from this morning? That username color issue should have been fixed.
I would not expect the content of the notification to change when editing another user's post which had nothing to do with the initial notification. Perhaps the issue is in that.
As Admin, I subscribed to a forum ...
- Create a new topic as a second user.
- Reply as a third user
- As Admin, edit the first post by second user
- Edit the 2nd post by the third user
Hope that helps.
Sorry, should have posted the full error.EXreaction wrote:You get an error that post_subject is not defined?
Code: Select all
[phpBB Debug] PHP Notice: in file [ROOT]/includes/notifications/type/post.php on line 216: Undefined index: post_subject
Re: [RFC] notification box
Excuse my English, I didn't pay attention to these linguistic differences. Actually when I said "you have joined/left group" I was thinking about the case of " you are added to or deleted from a group" as a the main goal.Pony99CA wrote:I don't think that you need to be notified when you join or leave a group; you should probably be notified when you are added to or deleted from a group by somebody else.Avdon wrote:+1Jessica. wrote:how about notification of a request to join a group? (https://www.phpbb.com/customise/db/mod/ ... er_needed/)
Also I think a notification of an event : you have joined/left group , would be very useful.
- imkingdavid
- Registered User
- Posts: 1050
- Joined: Thu Jul 30, 2009 12:06 pm
Re: [RFC] notification box
As long as extensions are able to add new notification types, we do not need to focus necessarily on putting all possible types in this RFC; what should be focused on here is simply the framework. We can of course discuss more notification types in the future.Pony99CA wrote:However, these might be new features that require their own RFC. I presume this RFC is just for handling existing notifications, not designing new ones (although notifying Moderators of posts in the queue might be new).
If I have the time today, I will have another look at this since it seems to be coming along fairly quickly.