[RFC|Merged] Extension Admin

[imkingdavid]

Hmm, looking at it, the install instructions are wrong. Instead of putting it in ./ext/naderman/example/ you should try putting it in ./ext/example/ and see if using ?ext=example works now.

[MichaelC]

Hmm, looking at it, the install instructions are wrong. Instead of putting it in ./ext/naderman/example/ you should try putting it in ./ext/example/ and see if using ?ext=example works now.

No, that change was on purpose. All extensions should be in ext/<vendor>/<extname>/.

[imkingdavid]

Well the change wasn't complete. https://github.com/naderman/phpbb3-exam ... roller.php The class is still phpbb_ext_example_controller when it should be phpbb_ext_naderman_example_controller. Either change that or change the installation directions.

EDIT: And it looks like most of the classes need to be changed.

[MichaelC]

Well the change wasn't complete. https://github.com/naderman/phpbb3-exam ... roller.php The class is still phpbb_ext_example_controller when it should be phpbb_ext_naderman_example_controller. Either change that or change the installation directions.

EDIT: And it looks like most of the classes need to be changed.

Ah my mistake, I assumed it had already been done elsewhere.

[oddfish]

Is this an issue with mysql dbms?

[MichaelC]

Is this an issue with mysql dbms?

Is what an issue?

[oddfish]

never mind, wrong RFC.

[Pony99CA]

This is mostly complete, some screenshots:

http://www.diigo.com/item/image/2xrwi/iosr?size=o
http://www.diigo.com/item/image/2xrwi/95qu?size=o

Does the UI still look like those screen captures? If so, I would like to suggest having Activate, Deactivate, Purge and/or Delete buttons (as appropriate) on the details page. If I'm looking at an extension in the list view, I may not have enough information to decide what I want to do, so I'll look at the details page. If I can't take action there, I have to waste time going back to the lists.

Also, I'm not completely familiar with how extensions work under the covers, so forgive me if I'm way off base here, but are there scenarios where you might have one extension whose execution is dependent on another's? If so, how is that order enforced? If there's no dependency item in the manifest, should there be up/down buttons in the Extensions Manager to control their order of execution?

Steve

[oddfish]

This is probably more up to date with what is happening

details.gif (32.03 KiB) Viewed 1738 times

I don't think anything else is needed in the detail page as it is for detail and not for purging or enabling.

[imkingdavid]

Also, I'm not completely familiar with how extensions work under the covers, so forgive me if I'm way off base here, but are there scenarios where you might have one extension whose execution is dependent on another's? If so, how is that order enforced? If there's no dependency item in the manifest, should there be up/down buttons in the Extensions Manager to control their order of execution?

As far as I know, allowing extensions to specify dependencies was decided against (though I think it would have been a good idea). A sort of hackish way to do this is to check in your extension code for a table or event or something unique about the extension you depend on. If it doesn't find that, then your extension should just not run regardless of being enabled.