Keep search query when search returns no results

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The current feature release of phpBB 3 is 3.3/Proteus.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.3.x. If you need support for phpBB 3.3.x please visit the 3.3.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Post Reply
dhruv.goel92
Registered User
Posts: 22
Joined: Sun Mar 18, 2012 9:30 pm

Re: Keep search query when search returns no results

Post by dhruv.goel92 »

So a notice saying "You requested page X but there are only Y pages in this result set, page Y is shown" or redirection to the last valid page?
Top
Senky
Extension Customisations
Extension Customisations
Posts: 315
Joined: Thu Jul 16, 2009 4:41 pm

Re: Keep search query when search returns no results

Post by Senky »

Notice is much better! It is never bad to show more info, than to show it less and confuse users...
Top
dhruv.goel92
Registered User
Posts: 22
Joined: Sun Mar 18, 2012 9:30 pm

Re: Keep search query when search returns no results

Post by dhruv.goel92 »

This is how i have done as of now - https://github.com/phpbb/phpbb3/pull/864 It can be modified to do redirection as well
Top
Post Reply

Return to “[3.x] Discussion”