Currently when No results are found for a search query, trigger_error function is called which results in search box being empty.
The search box in my opinion should contain the keywords even if no results were found.
Keep search query when search returns no results
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.3.x. If you need support for phpBB 3.3.x please visit the 3.3.x Support Forum on phpbb.com.
If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.3.x. If you need support for phpBB 3.3.x please visit the 3.3.x Support Forum on phpbb.com.
If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
-
- Registered User
- Posts: 22
- Joined: Sun Mar 18, 2012 9:30 pm
Re: [RFC] Keep search query when search returns no results
Yup, I agree. Don't think there's much need for an RFC for this, I'll move it to discussion. Just create a ticket and implement it
-
- Registered User
- Posts: 22
- Joined: Sun Mar 18, 2012 9:30 pm
Re: Keep search query when search returns no results
What should be the correct thing to do in case user tries to go to a result page which doesn't exist by changing start = parameter in the link,
an error like - "This Search Result Page is not valid" ? or maybe redirection to the last result page?
an error like - "This Search Result Page is not valid" ? or maybe redirection to the last result page?
Re: Keep search query when search returns no results
Error is better IMO - otherwise they can be confused.
Re: Keep search query when search returns no results
The problem with error return there is the user did nothing to provoke the error - search result set changed under the user, probably without any actions on user's part.
- DavidIQ
- Customisations Team Leader
- Posts: 1904
- Joined: Thu Mar 02, 2006 4:29 pm
- Location: Earth
- Contact:
Re: Keep search query when search returns no results
Looks to me like the question is if the user messes around with the query string what should the result be:
So yes, the user did provoke the error and error message should be shown.dhruv.goel92 wrote:What should be the correct thing to do in case user tries to go to a result page which doesn't exist by changing start = parameter in the link,
an error like - "This Search Result Page is not valid" ? or maybe redirection to the last result page?
- bantu
- 3.0 Release Manager
- Posts: 557
- Joined: Thu Sep 07, 2006 11:22 am
- Location: Karlsruhe, Germany
- Contact:
Re: Keep search query when search returns no results
No.DavidIQ wrote:Looks to me like the question is if the user messes around with the query string what should the result be:So yes, the user did provoke the error and error message should be shown.dhruv.goel92 wrote:What should be the correct thing to do in case user tries to go to a result page which doesn't exist by changing start = parameter in the link,
an error like - "This Search Result Page is not valid" ? or maybe redirection to the last result page?
Oleg's concern is as follows:
1. User searches and finds 2 pages of search results.
2. Moderator deletes a few posts. The search index changes.
3. User navigates to the second pages and gets the error (unprovoked).
-
- Registered User
- Posts: 22
- Joined: Sun Mar 18, 2012 9:30 pm
Re: Keep search query when search returns no results
We can in that case display a link to the last page perhaps with the error something like " This page was not found/deleted" Click Here to go back to page 1 ?