Drop distinction between style name and style path

[naderman]

Introduction

Styles currently have a style name which is displayed to users, and a style path which is the directory in phpBB/styles/ that the style resides in. However these are used incorrectly in somce places already, since they are typically identical. In https://github.com/phpbb/phpbb3/pull/690 the question came up why we differentiate at all.

Proposal
Remove the style_path. Require that phpBB/style/<style_name> exist, and load all templates themes and assets from that directory.

Patch
Ticket: http://tracker.phpbb.com/browse/PHPBB3-10829
PR: https://github.com/phpbb/phpbb3/pull/1072

[A_Jelly_Doughnut]

Would style names be limited to [a-z0-9. _-] (or whatever regex actually denotes is valid directory name on *NIX and Windows), or would there be some substiution such that a Christmas-themed style called Noël gets mapped to /styles/Nol (for a completely arbitrary example)

[naderman]

No, style names would be limited to [a-z0-9_-]

[brunoais]

So you are trashing any name that is foreign and does not conform with ANSI even though it conforms with UTF-8?
E.g. (lame name but...) "O tema do João"

[callumacrae]

+1

[Jocelyn79]

I agree with brunoais.
I want to keep the possibility to name my phpbb styles using spaces and any accented character (commonly used in many languages, including german, portuguese, french...and many more!).
Please keep style_path!

[Arty]

+1

It is very confusing for styles hierarchy when style can have different name and path. Using only directory name makes things much easier. Nobody cares about style name anyway, all visitors just use whatever is set as default style and never even know its name.

[ecwpa]

Now that you mention it, if the board administrator disable the option for users to pick a style, shouldn't that option be hidden to users then? Same goes for boards with only one language. Those are 2 options doing nothing on a lot of boards.

[DavidIQ]

The style selector is already not shown in the UCP when the Override user style option is set to Yes in ACP -> Board Settings.

[naderman]

Now that you mention it, if the board administrator disable the option for users to pick a style, shouldn't that option be hidden to users then? Same goes for boards with only one language. Those are 2 options doing nothing on a lot of boards.

Yes, I agree. Please create a ticket on our tracker at http://tracker.phpbb.com that we should remove that option if only one style is available.