[RFC|Merged] Template tag to include JS files

[hanakin]

I would think that is kind of a no brainer as HTML loads top down why would it change the order?

[Arty]

Ticket: http://tracker.phpbb.com/browse/PHPBB3-10665
Patch: https://github.com/cyberalien/phpbb3/tree/ticket/10665

Patch is not available as pull request yet because it is based on another pull request.

Also moved to 3.1 forum.

[naderman]

When you create wiki articles for transitioning to 3.1 please make sure they are linked to from http://wiki.phpbb.com/phpBB3.1 so they are easy to find.

[Arty]

Done. Updated wiki with all major style changes.

[igorw]

This does not work for assets though, right?

[brunoais]

This does not work for assets though, right?

How come?
It makes no real sense if it was made in such way that it doesn't... (I hope I understood it right)

[igorw]

Not as in not yet.

[Oleg]

The test has this code:

Code: Select all

		// Prepare correct result
		$dir = dirname(__FILE__);
		$scripts = array(
			'<script src="' . $dir . '/templates/parent_and_child.html?assets_version=1"></script>',
			'<script src="' . $dir . '/parent_templates/parent_only.html?assets_version=1"></script>',
			'<script src="' . $dir . '/templates/child_only.html?assets_version=1"></script>'
		);

		// Run test
		$cache_file = $this->template->cachepath . 'includejs.html.php';
		$this->run_template('includejs.html', array('PARENT' => 'parent_only.html'), array(), array(), implode('', $scripts), $cache_file);

Why are filesystem paths ending up in script tags?

Also please note the following additional tickets filed:

http://tracker.phpbb.com/browse/PHPBB3-10800
http://tracker.phpbb.com/browse/PHPBB3-10799

[Arty]

Why are filesystem paths ending up in script tags?

Because of this: https://github.com/phpbb/phpbb3/blob/de ... se.php#L66
and this: https://github.com/phpbb/phpbb3/blob/de ... ee.php#L21

[Oleg]

That needs to be changed/fixed then? Is there a ticket filed to fix it? Was this discussed anywhere?

I stopped blaming that code when I got to https://github.com/phpbb/phpbb3/commit/ ... c89a53d0c5.