[RFC|Merged] Extensions

[naderman]

Yup, certainly a bug.

[Oleg]

Factor a superclass out of the template locator?

[Erik Frèrejean]

Per IRC.

Code: Select all

[10:16PM]erikfrerejean:  Will authentication modules also be handled through the extension system? I'm looking into adding a new authentication module but don't want to put it in `includes/auth/`, currently however that isn't possible as they are "hard" included from that directory
[10:21PM] erikfrerejean:  Apparently it should be (http://area51.phpbb.com/phpBB/viewtopic.php?f=84&t=41499) though `session.php` doesn't seem to reflect that. Or am I overlooking something?
[10:35PM]igorw:  erikfrerejean: afaik auth plugins are already loadable through the ext system
[10:37PM]igorw:  at least I recall naderman claiming they were
[10:37PM] igorw: however, I recall not finding anything in the phpBB source
[10:38PM] igorw: as per your comment regarding sessino.php
[10:39PM]erikfrerejean:  igorw: https://github.com/phpbb/phpbb3/blob/develop/phpBB/includes/session.php#L396
[10:39PM] erikfrerejean: looks like the aren't
[10:39PM]igorw:  erikfrerejean: yep, and that piece of code is all over the place

The tracker seems to have some issues currently, so I'll post a ticket on this subject once that comes back online

[Erik Frèrejean]

Created ticket for that.

[nickvergessen]

See viewtopic.php?f=84&t=33438
I added "depends on" for your ticket.

[MichaelC]

See viewtopic.php?f=84&t=33438
I added "depends on" for your ticket.

Why does it depend on that? Auth plugins already exist and if that is not done then this still needs to be for the existing auth plugins system?

[nickvergessen]

Current auth plugins are function-based. So we can not autoload them from any specific files...

[Erik Frèrejean]

Current auth plugins are function-based. So we can not autoload them from any specific files...

Obviously not, and if refactoring the auth system won't be finished before 3.1 than at least it should be able to load an auth plugin from outside the /phpBB/includes/auth/ directory. Some sort of way to set the path to the expected auth plugins, through (for example) an additional (optional) parameter in the user class constructor. If you build a system that works next to phpBB and you need to add an auth plugin then you are forced to place it in that directory, which prevents you from creating a fully stand alone package.

[edit]
Or get rid of the include_once and check for the function.

Code: Select all

$method = basename(trim($config['auth_method']));
if (!function_exists($method))
{
    include($phpbb_root_path . 'includes/auth/auth_' . $method . '.' . $phpEx);
}

Than you can at least trick phpBB by including the custom auth plugin before calling the session code.[/i]

[KnocksX]

Where can I look up progress of the extensions work? Are there specific people assigned to it or is it free for all?

[EXreaction]

There are a couple of pull requests open that need a few issues fixed before a large portion of work can be merged in. A couple of people have been working on it and I've just started looking at it recently (I hope to start working on it soon too).

Are you interested in helping out? I can give you more specific information then.