[RFC] Stop Supporting Subsilver

[jsebean]

im happy with the decision to keep subsilver supported in 3.1, since i use subsilver myself. However, for 3.2 I would not be mad if you would stop supporting subsilver, in fact i think its a good idea, subsilver is based on tables for the layout which is out of standards anyway. Maybe someone just make a subsilver3, based on prosilver, but keep the same old looks in general since i like the looks of subsilver2.

That's the idea first we need to clean up pro then it would be easy enough to make a theme based off of it to resemble sub

To follow up on this post, someone did make a subsilver3, since I changed to it on my board (Makes things so much easier ) Though yes the post still makes sense. Anyone interested in subsilver3, i got no idea who made it but I think it's in the styles database.

[hanakin]

yes but its based off of prosilver which is a very old muttled piece of crap by todays standards

[callumacrae]

yes but its based off of prosilver which is a very old muttled piece of crap by todays standards

Do you have anything to back up this statement? I definitely disagree with you.

[hanakin]

yes but its based off of prosilver which is a very old muttled piece of crap by todays standards

Do you have anything to back up this statement? I definitely disagree with you.

apart from experience working with it and all forum software packages other than phpbb

the disscussion: viewtopic.php?f=108&t=35613

[MichaelC]

UKB|Debian> Whats going to happen with subsilver in the update? As its being removed from the default package. But what will happen with the updater package?
<UKB|Debian> Will the updater package include the subsilver updates, and if not, then will it un-install/delete subsilver or leave it or ..
<cyberalien> i'm not sure how to write a test for it
<igorw> UKB|Debian: I guess we'll include subsilver2 in the updater
<cyberalien> if(file_exists($phpbb_root_path . 'styles/subsilver2')) die('Please delete your forum.');
<UKB|Debian> ok, know its far off but what will then happen in 3.2
<cyberalien> that should do it for updater
<UKB|Debian> When its removed and stopped supported
<UKB|Debian> Will it un-install subsilver and delete it or ...?
<igorw> nobody knows

[Arty]

You forgot this part:

UKB|Debian: Arty: Syntax Error.
[12:09] UKB|Debian:
[12:09] igorw: UKB|Debian: where?
[12:10] igorw: I think you just nubbed yourself

[MichaelC]

You forgot this part:

UKB|Debian: Arty: Syntax Error.
[12:09] UKB|Debian:
[12:09] igorw: UKB|Debian: where?
[12:10] igorw: I think you just nubbed yourself

Thanks Arty. Not my fault your semi-colon was off the screen.

[imkingdavid]

<UKB|Debian> ok, know its far off but what will then happen in 3.2
<UKB|Debian> When its removed and stopped supported
<UKB|Debian> Will it un-install subsilver and delete it or ...?
<igorw> nobody knows

IMO This would be an acceptable approach (although we should really wait to discuss this later, after 3.1 is out):

1. If the board default theme is subsilver2 or based on subsilver2, switch it to prosilver. NOTE: If the board admin previously uninstalled prosilver and has no prosilver-based styles, the prosilver within the upgrade package should be installed onto the board and made default).
   
2. Deactivate subsilver2 (and all subsilver2-based themes) and switch users that were on those themes to the board default theme.
   
3. Display a notice/warning before and during upgrade process that this will happen, so that the admin does not freak out when their style is gone. Message should say that all subsilver2-based themes are being disactivated and that the user should search for acceptable prosilver-based themes to replace the subsilver2-based themes after the upgrade.

(because I'm too lazy to go back and change it myself, replace in your mind all above instances of "theme" with "style", since that's the correct terminology)

[MichaelC]

But a full version of prosilver won't ship with the update package. Only added files are shipped and if the whole thing is shipped it would wipe their current prosilver with all their edits.

[brunoais]

1. If the board default theme is subsilver2 or based on subsilver2, switch it to prosilver. NOTE: If the board admin previously uninstalled prosilver and has no prosilver-based styles, the prosilver within the upgrade package should be installed onto the board and made default).
   
2. Deactivate subsilver2 (and all subsilver2-based themes) and switch users that were on those themes to the board default theme.
   
3. Display a notice/warning before and during upgrade process that this will happen, so that the admin does not freak out when their style is gone. Message should say that all subsilver2-based themes are being disactivated and that the user should search for acceptable prosilver-based themes to replace the subsilver2-based themes after the upgrade.

(because I'm too lazy to go back and change it myself, replace in your mind all above instances of "theme" with "style", since that's the correct terminology)

We should just stop supporting subsilver2, not make it disappear from the internet or the current forums.
subsilver should just be deactivated and can be activated by board admins if they want to. Just don't expect that subsilver2 will ever be kept updated. Someone has to do that job and it's not the phpbb dev members.