It took a while until I realised it. Sorry for wasting your time. But maybe you can also take the suggestions and make an extension for 3.1 out of it.imkingdavid wrote:Fair enough. I just figured from the amount of support I had received that it might be a nice addition.Oleg wrote:Ideally this should be an extension that admins opt-in into.
[RFC|Rejected] Announcement Feed
- bantu
- 3.0 Release Manager
- Posts: 557
- Joined: Thu Sep 07, 2006 11:22 am
- Location: Karlsruhe, Germany
- Contact:
Re: [RFC] Announcement Feed
- imkingdavid
- Registered User
- Posts: 1050
- Joined: Thu Jul 30, 2009 12:06 pm
Re: [RFC] Announcement Feed
No worries; it didn't take long at all to adapt the MOD code into the code base. I'll most likely continue it for 3.1 when that comes out.bantu wrote:It took a while until I realised it. Sorry for wasting your time. But maybe you can also take the suggestions and make an extension for 3.1 out of it.imkingdavid wrote:Fair enough. I just figured from the amount of support I had received that it might be a nice addition.Oleg wrote:Ideally this should be an extension that admins opt-in into.
Re: [RFC] Announcement Feed
Personally I think this would be a good thing to display on the ACP (although not at the top). It would certainly allow us to engage the phpBB community more than we currently do. However I would probably simply implement this through an iframe rather than loading it and outputting it in the template. What do you guys think about that?
Re: [RFC] Announcement Feed
You cannot delete a pull request, but you can close it. Use the button on the bottom.
I like the iframe approach if it can be made to look reasonably well because then we're not injecting code from the internet on our pages. But then phpbb.com/whoever provides announcements has urls to installations via referer headers. Hmm.naderman wrote:Personally I think this would be a good thing to display on the ACP (although not at the top). It would certainly allow us to engage the phpBB community more than we currently do. However I would probably simply implement this through an iframe rather than loading it and outputting it in the template. What do you guys think about that?
Re: [RFC] Announcement Feed
Well if you don't want phpbb.com to get a referer header, then don't click the links. Besides, is the referer of an iframe link even the parent window and not the iframe url itself?
- callumacrae
- Former Team Member
- Posts: 1046
- Joined: Tue Apr 27, 2010 9:37 am
- Location: England
- Contact:
Re: [RFC] Announcement Feed
Just close it (theres a big button beside the comment form)imkingdavid wrote:Fair enough. I just figured from the amount of support I had received that it might be a nice addition. At least I got some more experience with the coding guidelines and using git and such. How do I delete a pull request?Oleg wrote:Ideally this should be an extension that admins opt-in into.
Re: [RFC] Announcement Feed
I think so yes, I will need to do some testing on that one as I am not 100% sure on it.naderman wrote:Well if you don't want phpbb.com to get a referer header, then don't click the links. Besides, is the referer of an iframe link even the parent window and not the iframe url itself?
- A_Jelly_Doughnut
- Registered User
- Posts: 1780
- Joined: Wed Jun 04, 2003 4:23 pm
Re: [RFC] Announcement Feed
What is the status on this? GitHub pull request was closed, but re-opened by David. Discussion here sounds like a down vote? Was there some back-channel discussion, or is this considered rejected?
A_Jelly_Doughnut
- imkingdavid
- Registered User
- Posts: 1050
- Joined: Thu Jul 30, 2009 12:06 pm
Re: [RFC] Announcement Feed
Sorry must have accidentally clicked reopen. I'll re-close it.A_Jelly_Doughnut wrote:What is the status on this? GitHub pull request was closed, but re-opened by David. Discussion here sounds like a down vote? Was there some back-channel discussion, or is this considered rejected?
Re: [RFC|Rejected] Announcement Feed
Marking rejected per previous post.