Removing config.php from git repository
Re: Removing config.php from git repository
It should have been removed a long time ago imo. Perhaps we can use .gitignore as a stop gap.
Re: Removing config.php from git repository
As per IRC, that will not work.ToonArmy wrote:Perhaps we can use .gitignore as a stop gap.
- Erik Frèrejean
- Registered User
- Posts: 207
- Joined: Thu Oct 25, 2007 2:25 pm
- Location: surfnet
- Contact:
Re: Removing config.php from git repository
Can you explain this for us that have missed the IRC explanation? I've thought of suggesting ".gitignore" as well but didn't manage to post it yet.eviL3 wrote:As per IRC, that will not work.ToonArmy wrote:Perhaps we can use .gitignore as a stop gap.
Available on .com
Support Toolkit developer
Support Toolkit developer
- bantu
- 3.0 Release Manager
- Posts: 557
- Joined: Thu Sep 07, 2006 11:22 am
- Location: Karlsruhe, Germany
- Contact:
Re: Removing config.php from git repository
It just doesn't work, it doesn't solve the problems that have been mentioned.Erik Frèrejean wrote:Can you explain this for us that have missed the IRC explanation? I've thought of suggesting ".gitignore" as well but didn't manage to post it yet.eviL3 wrote:As per IRC, that will not work.ToonArmy wrote:Perhaps we can use .gitignore as a stop gap.
from http://www.kernel.org/pub/software/scm/ ... gnore.htmlNote that all the gitignore files really concern only files that are not already tracked by git;
Re: Removing config.php from git repository
Yes the installer would need to be changed.bantu wrote:That doesn't seem to be true. I chmodded the phpBB folder to 777, but the install script keeps telling me "config.php - Cannot find".naderman wrote:Well the issue with that is that people are going to make the entire phpBB directory writable so it can create the file rather than making an empty config.php file writable so it can overwrite it.
We should probably make it so it redirects in both cases then.bantu wrote: I noticed another difference, but that shouldn't be an issue:
When the config.php file is there but empty and you visit phpBB/ you will be redirected to phpBB/install/index.php.
If it's not there you will get the messageCode: Select all
<p>The config.php file could not be found.</p><p><a href="./install/index.php">Click here to install phpBB</a></p>
- bantu
- 3.0 Release Manager
- Posts: 557
- Joined: Thu Sep 07, 2006 11:22 am
- Location: Karlsruhe, Germany
- Contact:
Re: Removing config.php from git repository
Do we want to do that? I mean you'll likely end up with having the phpBB folder world-writable.naderman wrote:Yes the installer would need to be changed.bantu wrote:That doesn't seem to be true. I chmodded the phpBB folder to 777, but the install script keeps telling me "config.php - Cannot find".naderman wrote:Well the issue with that is that people are going to make the entire phpBB directory writable so it can create the file rather than making an empty config.php file writable so it can overwrite it.
Re: Removing config.php from git repository
http://tracker.phpbb.com/browse/PHPBB3-9830naderman wrote:We should probably make it so it redirects in both cases then.