Plugin code integration with core

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The current feature release of phpBB 3 is 3.3/Proteus.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.3.x. If you need support for phpBB 3.3.x please visit the 3.3.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
code reader
Registered User
Posts: 653
Joined: Wed Sep 21, 2005 3:01 pm

regarding Phorum:

Post by code reader »

ttbomk, in phorum a "plugins" does not modify even a single line of code, and that includes the template.

it is also true, that in *addition* to plugins, phorum also distribute more invasive modification that *do* modify the code.
in the phorum nomenclature these are called "hacks", and in general they are strongly discouraged.
it is my understanding that practically nobody is creating *new* phorum hacks: all new development is done purely through plugins/hooks.
the hacks that do exist are "legacy", and i think they are being replaced by plugins.

the phorum dev team is very responsive, and if/when a plugin developer finds out they need (want) a new hook where one does not currently exist, they ask the dev team for a new hook, and by the next minor version it will be there.

please note that the above is "to the best of my knowledge".

peace.

mrl586
Registered User
Posts: 2
Joined: Fri Jul 08, 2005 11:16 pm
Location: Tampere, Finland

Re: Plugin code integration with core

Post by mrl586 »

nn- wrote:Since plugin install modifies templates without user intervention I must assume either the entire template tree must be chmodded o+w or template edits are done in database only, which would create problems during updating, unless all plugins are uninstalled before updates and reinstalled later, which however unconditionally nukes db columns created by plugins, causing data loss, so hmm.
MyBB themes are locate in database.

topdown
Registered User
Posts: 12
Joined: Sat Dec 01, 2007 5:04 am

Re: Plugin code integration with core

Post by topdown »

On the WordPress note, their plug-ins do not go through any kind of validation like phpBB Mod teams do.
Their requirements are very basic at best, the readme file and the comment at the top of the main plug-in file which is what the Admin Plug-in page shows for info about the plug-in itself. The readme is what their system uses for the plug-in repository.

Point is, the code in 99% of the WP plug-ins are either worse than the WP code itself or a good percentage fail working at all because the coder winged it.

WordPress code is not pretty at all, mostly because of the constant backwords compatibility they keep.
If they did a complete re-write ignoring backwords compatibility I am sure it would be much better than it is.

What I do like is the way they hook everything, it is not pretty, definitely not optimal but its simple and it works.
Not the way I would do it, but it is what it is.


If Rhea is written in full OPP, including the controllers (viewforum, index, viewtopic, etc...)
Most things could be done with extending or overloading methods.
Others could be done with a very simple and light hook system, unlike what we have now.

I personally do not like the thought of any type of mod system that is going to edit the core in any way or form.

Post Reply