[RFC] Define max-width for prosilver
Re: Define max-width for prosilver
they do in safari, not sure what VSE is using, but even in chrome I would like to see more than 12px on the bottom
Re: Define max-width for prosilver
Safari. But that shouldn't really matter as there is now browser inconsistency. it's a byproduct of this change:PayBas wrote:I agree that maybe 12/15px is odd (although hardly a big problem), but which browser are you using?
The rounded corners at the bottom do not reach the bottom of my screen. There's a margin there.
https://github.com/phpbb/phpbb/pull/268 ... a8bfbbcL62
Has an irascible disposition.
Re: Define max-width for prosilver
Problem in safari now comes from the current changes mixed with: html height: 101%
Is the scrollbar jump still really an issue anymore (it's not in Macs, we have hidden scrollbars)?
if not, remove html height: 101%
-or-
Put back padding: 12px 0; on the body and remove the 12px margins added to wrap.
This should fix it:
https://github.com/phpbb/phpbb/pull/2694
Is the scrollbar jump still really an issue anymore (it's not in Macs, we have hidden scrollbars)?
if not, remove html height: 101%
-or-
Put back padding: 12px 0; on the body and remove the 12px margins added to wrap.
This should fix it:
https://github.com/phpbb/phpbb/pull/2694
Has an irascible disposition.
Re: Define max-width for prosilver
Just a thought, wouldn't it be cleaner to not have rounded borders and top/bottom padding/margins:
Has an irascible disposition.
Re: Define max-width for prosilver
Please change the BG color first...VSE wrote:Another thought, wouldn't it be cleaner to not have rounded borders and top/bottom padding/margins:
-
- Registered User
- Posts: 523
- Joined: Sat Apr 22, 2006 10:29 pm
- Contact:
Re: Define max-width for prosilver
Disagree... Looks better as is.VSE wrote:Just a thought, wouldn't it be cleaner to not have rounded borders and top/bottom padding/margins:
Re: Define max-width for prosilver
Why not? Is there an easier way to prevent scroll bar jump issues on PCs:VSE wrote: if not, remove html height: 101%
Code: Select all
html {
height: 100%;
overflow-y: scroll;
}
Sorry for my English.
Re: Define max-width for prosilver
This is from 8 Apr 2007.Sumanai wrote:Why not? Is there an easier way to prevent scroll bar jump issues on PCs:VSE wrote: if not, remove html height: 101%
Code: Select all
html { height: 100%; overflow-y: scroll; }
I agree that we could probably do away with the height altogether and use the overflow-y.Always show a scrollbar for short pages - stops the jump when the scrollbar appears
Would need some extensive browser testing though.
Re: Define max-width for prosilver
I've used the overflow-y technique instead of height: 101% in the past with success.PayBas wrote:I agree that we could probably do away with the height altogether and use the overflow-y.
Would need some extensive browser testing though.
Has an irascible disposition.
Re: Define max-width for prosilver
Would also like to see the gradient.gif removed that gets used on forum listings. On my forum I've made it a fully transparent image instead so you don't get that gradient effect shown, looks cleaner and better like topic listings not using it. When you have different category sections (with some containing more forums under it than other categories). That gradient background used on forums listed under each CAT can look different shades, darker for some CAT's with less forums - lighter for other CAT's with more listed forums under it.
It doesn't have a same uniformed look on forum home (with forums listed under CAT) because of it. As the image below shows you because 2nd CAT has many more forums listed under it than first one - making the lighter part of the gradient image be used for those forums.
How it looks on my forum using a fully transparent gradient.gif image to stop that happening.
It doesn't have a same uniformed look on forum home (with forums listed under CAT) because of it. As the image below shows you because 2nd CAT has many more forums listed under it than first one - making the lighter part of the gradient image be used for those forums.
How it looks on my forum using a fully transparent gradient.gif image to stop that happening.
Last edited by mrgtb on Sun Jul 06, 2014 1:05 pm, edited 1 time in total.