[RFC] Combine Related functionality (UI Cleanup)

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Post Reply
User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 968
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: Combine all search related functionality

Post by hanakin »

ok round again?

I switched up the mod/acp links and gave the quick look some treatment

Still fighting for the profile on the left though as per my last post
Screen Shot 2014-06-05 at 12.25.38 AM.png
(81.85 KiB) Downloaded 644 times
still need suggestions on the faq & members as they dont really fit anywhere
Donations welcome via Paypal Image

User avatar
Louis7777
Registered User
Posts: 394
Joined: Fri Apr 04, 2014 12:32 am

Re: Combine all search related functionality

Post by Louis7777 »

In my opinion, the fag and members should be somewhere together with "The team", although there's not much space at the footer...

keith10456
Registered User
Posts: 523
Joined: Sat Apr 22, 2006 10:29 pm
Contact:

Re: Combine all search related functionality

Post by keith10456 »

I agree that FAQ and Members links should be in the Footer...

I like where you have ACP and MCP (here). There's no reason for them to have a separate line in the header... That just takes-up space unnecessarily.

The icon (...) for "Your Posts", "Unanswered Posts", etc seems like it's being hidden and one wouldn't know what it is for upon seeing it. Why not add a name for it, put it the same place as the Username (and Avatar) along with Notifications, etc.... Move all of it all the way to the left, then put the Search where Username, etc currently is in this one.


* Edit - I see you named "Your Posts", "Unanswered Posts" etc to "Quick Links". Great!

Marshalrusty
Project Manager
Project Manager
Posts: 273
Joined: Thu Oct 27, 2005 1:45 am

Re: Combine all search related functionality

Post by Marshalrusty »

hanakin wrote:ok round again?

I switched up the mod/acp links and gave the quick look some treatment

Still fighting for the profile on the left though as per my last post
Screen Shot 2014-06-05 at 12.25.38 AM.png
still need suggestions on the faq & members as they dont really fit anywhere
Wow, we're really getting somewhere. I have no complaints.

I don't really see the problem with the FAQ and Memberlist links in the top left where I had them.

User avatar
PayBas
Registered User
Posts: 305
Joined: Tue Jul 29, 2008 6:08 pm
Contact:

Re: Combine all search related functionality

Post by PayBas »

As the code stands now (ITS A WIP!). I'll finish it tomorrow or this weekend.
navbar-revamp3.png
(21.33 KiB) Downloaded 610 times
Damn it was a lot work, but I split the PR's, so we're starting clean. New ticket, new PR.

Ticket: https://tracker.phpbb.com/browse/PHPBB3-12662
PR: https://github.com/phpbb/phpbb/pull/2550

keith10456
Registered User
Posts: 523
Joined: Sat Apr 22, 2006 10:29 pm
Contact:

Re: Combine all search related functionality

Post by keith10456 »

Looks good... Nice comprise from all of the received suggestions, comments, etc ;-)

Question: What about the breadcrumbs concern previously mentioned? Was a workaround found?

User avatar
Sumanai
Registered User
Posts: 95
Joined: Sat Aug 31, 2013 11:12 am

Re: Combine all search related functionality

Post by Sumanai »

PayBas, can shorten the name "Moderator Control Panel" and "Administration Control Panel" to "MCP" and "ACP", respectively?
If find suitable icon, problems with it will not.
Sorry for my English.

User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 968
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: Combine all search related functionality

Post by hanakin »

Sumanai wrote:PayBas, can shorten the name "Moderator Control Panel" and "Administration Control Panel" to "MCP" and "ACP", respectively?
If find suitable icon, problems with it will not.
thats a bad can of worms
Donations welcome via Paypal Image

User avatar
PayBas
Registered User
Posts: 305
Joined: Tue Jul 29, 2008 6:08 pm
Contact:

Re: Combine all search related functionality

Post by PayBas »

hanakin wrote:
Sumanai wrote:PayBas, can shorten the name "Moderator Control Panel" and "Administration Control Panel" to "MCP" and "ACP", respectively?
If find suitable icon, problems with it will not.
thats a bad can of worms
:lol:, understatement

User avatar
PayBas
Registered User
Posts: 305
Joined: Tue Jul 29, 2008 6:08 pm
Contact:

Re: Combine all search related functionality

Post by PayBas »

Current code:
1.png
(11.65 KiB) Downloaded 540 times
Current JS:
2.png
(10.91 KiB) Downloaded 540 times
Wanted JS:
3.png
(10.91 KiB) Downloaded 540 times
As you can see. The responsive breadcrumb JS kicks in before the responsive "data-responsive-text" on the ACP/MCP. I need to figure out the priorities.

p.s. Yes I know the icons are not 100% yet.

Post Reply