[RFC|Merged] Breadcrumb microdata

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
User avatar
Arty
Former Team Member
Posts: 985
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Breadcrumb microdata

Post by Arty »

Created ticket and pull request: https://github.com/phpbb/phpbb3/pull/1041

Prosilver version is straight forward, subsilver2 version is a bit more complex. Breadcrumbs in subsilver2 are included twice, but microdata must be displayed only once, so I've used DEFINE to prevent duplicate microdata.

Do you think solution for subsilver2 is ok or too complex? If its too complex, then subsilver2 can live without microdata.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC] Breadcrumb microdata

Post by nickvergessen »

looks fine for me
Member of the Development-TeamNo Support via PM

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC|Merged] Breadcrumb microdata

Post by Oleg »

Merged.

User avatar
Meis2M
Registered User
Posts: 448
Joined: Fri Apr 23, 2010 10:18 am
Contact:

Re: [RFC|Merged] Breadcrumb microdata

Post by Meis2M »

is it work on rtl language too? ( right to left )

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC|Merged] Breadcrumb microdata

Post by nickvergessen »

It is independent.
Member of the Development-TeamNo Support via PM

User avatar
DionDesigns
Registered User
Posts: 51
Joined: Sat Apr 21, 2012 4:29 am
Location: Uncertain due to momentum
Contact:

Re: [RFC|Merged] Breadcrumb microdata

Post by DionDesigns »

There is a new standard for microdata: http://schema.org/docs/gs.html

This RFC is Google-specific; the new standard is supported by Google, Bing, Yahoo, and Yandex.

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC|Merged] Breadcrumb microdata

Post by Oleg »

We are going to need a new patch then.

User avatar
Volksdevil
Registered User
Posts: 84
Joined: Tue Sep 04, 2012 2:17 pm
Contact:

Re: [RFC|Merged] Breadcrumb microdata

Post by Volksdevil »

Hmm. I've been using microdata from http://www.data-vocabulary.org for quite some time now, didn't realise there was a new standard. Does this mean I need to remove everything I added via http://www.data-vocabulary.org and replace with stuff from schema.org?


User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC|Merged] Breadcrumb microdata

Post by nickvergessen »

It is marked as merged, just try and have a look at the source code of the area51.phpbb.com header ;)
Member of the Development-TeamNo Support via PM

Post Reply