[RFC|Merged] Pagination as <ul> list

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Pagination as <ul> list

Post by naderman »

Looks good :)

Danielx64
Registered User
Posts: 304
Joined: Mon Feb 08, 2010 3:42 am

Re: [RFC] Pagination as <ul> list

Post by Danielx64 »

+1 from me

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Pagination as <ul> list

Post by imkingdavid »

It is my opinion that we should move toward putting all instances of markup such as this into the template files instead of in the PHP. That makes it much more flexible and such. So +1 from me.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Pagination as <ul> list

Post by naderman »

We might actually want to place this in a separate template file if we haven't already, so it's not copied and pasted over the place.

User avatar
psoTFX
Registered User
Posts: 1984
Joined: Tue Jul 03, 2001 8:50 pm
Contact:

Re: [RFC] Pagination as <ul> list

Post by psoTFX »

I pulled out common pagination into a new template which is included where needed. Where it's embedded within a block I retained it as-is.

User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Pagination as <ul> list

Post by naderman »

We really should have a mechanism that makes that unecessary. New template RFC?

User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Pagination as <ul> list

Post by naderman »

Actually, we seem to already have one: viewtopic.php?f=108&t=29699

User avatar
jsebean
Registered User
Posts: 165
Joined: Wed Nov 17, 2010 1:40 am
Location: Atlantic Canada

Re: [RFC] Pagination as <ul> list

Post by jsebean »

Meis2M wrote:and +2
Since you can only vote once (is that a rule? :lol: ), I claim the second one ;)
-Jonah

User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Pagination as <ul> list

Post by naderman »

This change has been merged. https://github.com/phpbb/phpbb3/pull/877

User avatar
Meis2M
Registered User
Posts: 432
Joined: Fri Apr 23, 2010 10:18 am
Contact:

Re: [RFC|Merged] Pagination as <ul> list

Post by Meis2M »

is there any option from acp to active or deactive this tools?

Post Reply