[RFC|Merged] notification box

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Post Reply
User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 674
Joined: Mon Mar 08, 2010 9:18 am

Re: [RFC] notification box

Post by VSE »

TheKiller wrote:

Code: Select all

border-left: 10px dashed transparent;
border-right: 10px dashed transparent;
background: transparent;
I am most probably mistaken here, but.. Is this really required ?
Why do you have to set/define the colour as transparent? Dosent it display the same results with or without the colour defined as transparent?
You do need transparent, just in case, for potential browser gotchas... especially because of IE6...as usual...It may not be required, but it doesn't hurt to have it..for safety.
Has an irascible disposition.
User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: [RFC] notification box

Post by Dragosvr92 »

Um, true, but we could check how it looks in those browsers and be sure if the transparent thingie is needed or not.
Previous user: TheKiller
Avatar on Memberlist 1.0.3
User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 674
Joined: Mon Mar 08, 2010 9:18 am

Re: [RFC] notification box

Post by VSE »

TheKiller wrote:Um, true, but we could check how it looks in those browsers and be sure if the transparent thingie is needed or not.
I did. It looks like we don't need it for background after all. But it is a must for the borders left and right...it's a CSS trick to create triangles. See: http://css-tricks.com/snippets/css/css-triangle/
Has an irascible disposition.
User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: [RFC] notification box

Post by Dragosvr92 »

Oh, i see, thats nice ! O-o
Was just trying to make sure there wont be any extra code that isnt needed. :)

Do you have an online demo on the development of the notification menu, or is it just locally for you? I'd ilke to follow how it develops.
I hope it will get added on here soon.

EDIT:
What about some round corners around the notification box?
Previous user: TheKiller
Avatar on Memberlist 1.0.3
User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 674
Joined: Mon Mar 08, 2010 9:18 am

Re: [RFC] notification box

Post by VSE »

TheKiller wrote:Oh, i see, thats nice ! O-o
Was just trying to make sure there wont be any extra code that isnt needed. :)

Do you have an online demo on the development of the notification menu, or is it just locally for you? I'd ilke to follow how it develops.
I hope it will get added on here soon.

EDIT:
What about some round corners around the notification box?
If you're a githubber, you can download it from Github... There is a Pull Request for it by EXreaction, you can follow that PR to his branch and you could download that branch and demo it locally for yourself that way.

As for rounded corners, they would look like this. Any opinions from people here?
Screen Shot 2012-12-28 at 8.11.09 PM.png
Screen Shot 2012-12-28 at 8.11.09 PM.png (62.41 KiB) Viewed 5833 times
Has an irascible disposition.
User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: [RFC] notification box

Post by Dragosvr92 »

I have an account there for a while, but i am not sure i know how to use github properly.
I cant even install phpbb 3.0.11 properly with QI due to the recent php version anymore.

I think it looks a lot better that way.
Previous user: TheKiller
Avatar on Memberlist 1.0.3
User avatar
callumacrae
Former Team Member
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] notification box

Post by callumacrae »

Looks a lot better with rounded corners!
Made by developers, for developers!
My blog
User avatar
Jessica.
Registered User
Posts: 144
Joined: Wed Feb 09, 2011 8:17 pm
Location: Pennsylvania, USA
Contact:

Re: [RFC] notification box

Post by Jessica. »

Oh, yes, it looks much better with rounded corners!!
User avatar
Mess
Registered User
Posts: 199
Joined: Wed Jun 13, 2012 10:14 am

Re: [RFC] notification box

Post by Mess »

+1 for rounded corners. :)
keith10456
Registered User
Posts: 523
Joined: Sat Apr 22, 2006 10:29 pm
Contact:

Re: [RFC] notification box

Post by keith10456 »

Looks awesome!

Is each notification row (the entire row) a linklink (ex: I can click any where in the row) or is certain text in the notification row a link?

Image
Post Reply