[RFC|Merged] notification box
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] notification box
No, I mean that the method to notify users is abstracted for this notifications system, so in each method you have to set up the calls to send alerts or notifications to users. A more flexible system to send out notifications in phpBB itself would make it easier, but that is a separate item to be tackled.
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] notification box
I've gotten a good bit of work done on it today, mainly backend related to get the tests working though, so not too much to actually see.
This is fixed.oddfish wrote:Code: Select all
Fatal error: SQL ERROR [ mysqli ] Table '31_noti.phpbb_notifications' doesn't exist [1146] SQL SELECT COUNT(*) AS count FROM phpbb_notifications WHERE user_id = 2 AND unread = 1 in /public_html/noti/includes/db/dbal.php on line 809
As for this, I personally hate confirmation messages when they are unnecessary. I'd prefer to add a message that shows up on the page after submitting that their preferences were updated, but this is not how phpBB works anywhere else. Are there any opinions on this?oddfish wrote:Submit selection/s in UCP -> Overview .. Notification options shows no confirmation.
Seems to work for me. This is something browsers handle themselves, so if it doesn't work, there may be an issue with your browser.oddfish wrote:Reset does nothing.
Are you subscribed to the topic?oddfish wrote:SelectingSomeone replies to a topic you are subscribed to
andSomeone creates a topic in a forum you are subscribed to
does not notify user of a reply.
- Pony99CA
- Registered User
- Posts: 986
- Joined: Sun Feb 08, 2009 2:35 am
- Location: Hollister, CA
- Contact:
Re: [RFC] notification box
What about the flash message RFC?EXreaction wrote:As for this, I personally hate confirmation messages when they are unnecessary. I'd prefer to add a message that shows up on the page after submitting that their preferences were updated, but this is not how phpBB works anywhere else. Are there any opinions on this?oddfish wrote:Submit selection/s in UCP -> Overview .. Notification options shows no confirmation.
Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] notification box
If it was already merged, then I would say yes.
- oddfish
- Registered User
- Posts: 110
- Joined: Tue Mar 27, 2007 5:53 am
- Location: on my way home
- Contact:
Re: [RFC] notification box
Issue with editing a post :
Reset is good.
Install is good.
Selecting the previous options in UCP is good.
Will check on notification order when error is sorted.
Original testing and current on Chrome and FF (Debian), FF nightly and IE10 (win8).
Preference for Submit has always been Submit changes to Submitted and non functional till selection is changed but for phpBB3.1? .. anything to give the user a confirmation that "da button done good".
EDIT: NOTIFICATION TYPE .. should it matter that the order is different between platform installs?
Code: Select all
Fatal error: Call to a member function add_notifications_for_users() on a non-object in ../public_html/noti/includes/notification/type/quote.php on line 171
Install is good.
Selecting the previous options in UCP is good.
Will check on notification order when error is sorted.
Original testing and current on Chrome and FF (Debian), FF nightly and IE10 (win8).
Preference for Submit has always been Submit changes to Submitted and non functional till selection is changed but for phpBB3.1? .. anything to give the user a confirmation that "da button done good".
EDIT: NOTIFICATION TYPE .. should it matter that the order is different between platform installs?
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] notification box
Error has been fixed.
For now, I am just going with the current standard of using trigger_error with a meta refresh. As much as I hate it, inconsistency would be worse.
As for the order issue, I am not sure why that happens, but I would like to at least group them later into categories.
For now, I am just going with the current standard of using trigger_error with a meta refresh. As much as I hate it, inconsistency would be worse.
As for the order issue, I am not sure why that happens, but I would like to at least group them later into categories.
- oddfish
- Registered User
- Posts: 110
- Joined: Tue Mar 27, 2007 5:53 am
- Location: on my way home
- Contact:
Re: [RFC] notification box
Changing From Overview to Board Preferences - template should change to fit with display options, posting defaults etc?
Notifications still changing when editing a post.
To refresh:
The original notification (the new topic) also changes to the current board time which correctly changes the order of notifications, as sorted by date, when more than 2 notifications.
The edited post's new notification appears under the original notification.
Editing User1 reply to User2 topic results in the same scenario.
Notifications still changing when editing a post.
To refresh:
- As Admin, subscribe to User1 (global moderator) topic.
- User2 (reg user) replies to User1 topic.
- As Admin, check notification.
- Edit User2 reply.
- Check notification.
The original notification (the new topic) also changes to the current board time which correctly changes the order of notifications, as sorted by date, when more than 2 notifications.
The edited post's new notification appears under the original notification.
Editing User1 reply to User2 topic results in the same scenario.
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] notification box
That should be fixed now
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] notification box
I've added some new notification types:
Reported pm/posts notification (for moderators)
Report closed notification
Also I will be adding a bumped topics notification type later.
Reported pm/posts notification (for moderators)
Report closed notification
Also I will be adding a bumped topics notification type later.
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] notification box
I think I've also completed the notification grouping part. So any consecutive replies to a topic will not generate new notification alerts if you have not read the topic yet.
If anyone is able to test more of this that would be fantastic. All I really have left is some UCP stuff, a little bit of work on the template output, and then porting to subsilver2.
If anyone is able to test more of this that would be fantastic. All I really have left is some UCP stuff, a little bit of work on the template output, and then porting to subsilver2.