Exactly what Senky said. It needs some javascript helper that allows you to select the username and insert it into the post, along with some sort of bbcode that can be matched with any containing data.
Two examples that would be fairly difficult and could cause issues with just @:
@a new user
@bl@h
If it uses something like [tag]a new user[/tag] then it's easy, but that requires custom bbcode, which is outside the scope of this.
[RFC|Merged] notification box
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
- callumacrae
- Former Team Member
- Posts: 1046
- Joined: Tue Apr 27, 2010 9:37 am
- Location: England
- Contact:
Re: [RFC] notification box
Yeah, but that looks horrific. @bl@h is fine, it's just usernames with spaces that would cause a problem, and there aren't many of them (it also causes problems on websites such as Stack Overflow, and they're dealing with it fine).
Can I suggest that we take this to the actual RFC?
Can I suggest that we take this to the actual RFC?
- Pony99CA
- Registered User
- Posts: 986
- Joined: Sun Feb 08, 2009 2:35 am
- Location: Hollister, CA
- Contact:
Re: [RFC] notification box
Or you add a new pre-defined BBCode for this. Then you could make clicking user names in the topic history display a menu to either view the person's profile or tag the user.EXreaction wrote:If it uses something like [tag]a new user[/tag] then it's easy, but that requires custom bbcode, which is outside the scope of this.
But that's probably outside the scope of this RFC as you said.
Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.
- Pony99CA
- Registered User
- Posts: 986
- Joined: Sun Feb 08, 2009 2:35 am
- Location: Hollister, CA
- Contact:
Re: [RFC] notification box
I also hope that this would be used to notify moderators that they had posts awaiting approval. (Wasn't there an RFC for that?) You may not want them getting subscription notifications, but in-board notifications would be great.
Steve
Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] notification box
Yes, that is planned.
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] notification box
It's at a state where it can start being tested more. See the opening post for the PR to see what's in it and what's left to do.
https://github.com/phpbb/phpbb3/pull/992
All the notification types that have been requested (besides username tagging) have been included so far.
https://github.com/phpbb/phpbb3/pull/992
All the notification types that have been requested (besides username tagging) have been included so far.
- oddfish
- Registered User
- Posts: 110
- Joined: Tue Mar 27, 2007 5:53 am
- Location: on my way home
- Contact:
Re: [RFC] notification box
Suggestions on "Prettify"
Nice work.
- Remove extended hover colour and line including the brackets on the [ Notifications ] in overall_header.html by removing [] around language string, adding them to overall_header.html
[ <a href="#" title="{L_NOTIFICATIONS}" onClick="$('#notification_list').toggle();">{L_NOTIFICATIONS}</a> ]
. This will then give you [ Notifications ]. Might require•
to separate UCP and (..Messages). - Grey background in notification needs a bertification somewhat (much prefer a changed font colour) - will see what ajax will do.
- Add the unread_count to the string, i.e. [ 3 Notifications ]. This might not be such a good idea considering messages has a count so probably too much for the loaction.
Nice work.
Re: [RFC] notification box
+1 for oddfish.
- oddfish
- Registered User
- Posts: 110
- Joined: Tue Mar 27, 2007 5:53 am
- Location: on my way home
- Contact:
Re: [RFC] notification box
A few quirks ..
- Separation needed between notifications (eg, horizontal line or bg2 bg1 but not sure what ajax will do).
- Notifications for bookmarked topics show time of Thu Jan 1st, 1970, 12:00pm - this changes to the correct board time when edited (i.e. a post). PM notifications show correctly.
- If a post is edited, the username loses its group colour assigned in the notification.
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] notification box
Thanks for all the hard work testing it, I will look into those issues.