That sounds like another phpBB bug. This does not modify any of the core code except where notifications take place, no action phpBB performs should change because of this.
I will check out that issue tomorrow.
[RFC|Merged] notification box
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] notification box
I cannot reproduce this, could you try it again?oddfish wrote:Another issue.
Admin approves a topic.
Global Moderator logs in and there is a new notification to approve the very same topic, unread. Of course there is no topic to approve.
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] notification box
Other than any new bugs I am not aware of, I'd say this is complete for prosilver.
I do have to make subsilver2 templates, but that's all that I have on my to-do list
I do have to make subsilver2 templates, but that's all that I have on my to-do list
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] notification box
Subsilver2 is now supported, this PR is all ready to review for merging.
-
- Registered User
- Posts: 523
- Joined: Sat Apr 22, 2006 10:29 pm
- Contact:
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] notification box
Thanks
- oddfish
- Registered User
- Posts: 110
- Joined: Tue Mar 27, 2007 5:53 am
- Location: on my way home
- Contact:
Re: [RFC] notification box
Yeah, I can be reproduce this and confirmed using g077c526 fresh install.EXreaction wrote:I cannot reproduce this, could you try it again?oddfish wrote:Another issue.
Admin approves a topic.
Global Moderator logs in and there is a new notification to approve the very same topic, unread. Of course there is no topic to approve.
- Moderator approves a topic in the MCP (not via notification), Admin logs in and there is a new notification, unread, to approve that topic.
- Admin approves a topic (again MCP). Notification still shows a new topic unread to approve.
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] notification box
I will try to reproduce it again.
Subsilver2 should now not display a blank square if the user does not have an avatar.
Subsilver2 should now not display a blank square if the user does not have an avatar.
Re: [RFC] notification box
There should probably be a wiki article on this (how to use it in extensions).
Formerly known as Unknown Bliss
No unsolicited PMs please except for quotes.psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] notification box
Yes, once it is in a final form (if anything else needs to be changed) and merged I will do that.