[RFC|Merged] notification box

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Post Reply
User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] notification box

Post by EXreaction » Fri Feb 15, 2013 7:36 pm

Someone really just needs to develop a proper language for displaying internet pages and find a way to transition the internet to it :)

I'll take a look at your PR later when I get some time.

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] notification box

Post by EXreaction » Fri Feb 15, 2013 10:03 pm

Added a settings link in the flyout menu and restored the PM link as it was.

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: [RFC] notification box

Post by VSE » Fri Feb 15, 2013 10:44 pm

EXreaction wrote:Someone really just needs to develop a proper language for displaying internet pages and find a way to transition the internet to it :)

I'll take a look at your PR later when I get some time.
Things seem to get ugly with three lines, the date wraps under the avatar. I think no padding for the date is the best option. (although, if you get up to four lines, the date wraps under the avatar too with or without padding)
Has an irascible disposition.

AliasEll
Registered User
Posts: 6
Joined: Thu Feb 28, 2013 2:39 pm

Re: [RFC] notification box

Post by AliasEll » Thu Feb 28, 2013 2:45 pm

This is really nice, something that should have been implemented into PHPBB quite a while ago :)

Is there any guesstimate on when this could be make into a proper mod (maybe not accepted, but at least a XML file for install etc).

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC|Merged] notification box

Post by imkingdavid » Thu Feb 28, 2013 11:59 pm

This was merged. Pull Request
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

FilipET
Registered User
Posts: 5
Joined: Fri Mar 01, 2013 12:16 pm

Re: [RFC|Merged] notification box

Post by FilipET » Fri Mar 01, 2013 12:19 pm

why merged?

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: [RFC|Merged] notification box

Post by Pony99CA » Sat Mar 02, 2013 3:11 am

imkingdavid wrote:This was merged. Pull Request
I think that he was asking if it could be made a phpBB 3.0 MOD.
FilipET wrote:why merged?
Huh? I believe that's how changes get into phpBB -- patches get merged.

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC|Merged] notification box

Post by imkingdavid » Sat Mar 02, 2013 4:39 am

Pony99CA wrote:
imkingdavid wrote:This was merged. Pull Request
I think that he was asking if it could be made a phpBB 3.0 MOD
My post wasn't in response to his; I just merged it so I was posting to say so. :P if someone wants to adapt that pull request into a mod they're more than welcome to do so.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC|Merged] notification box

Post by EXreaction » Sat Mar 02, 2013 3:38 pm

The amount of work required to make this work for 3.0 would probably be very significant.

User avatar
oddfish
Registered User
Posts: 110
Joined: Tue Mar 27, 2007 5:53 am
Location: on my way home
Contact:

Re: [RFC|Merged] notification box

Post by oddfish » Sat Mar 02, 2013 11:35 pm

A couple of thoughts.

1. Remove read private messages from notifications or at least a Remove button next to Mark read?

2. Remove pagination from Manage notifications when empty which then brings it into line with Manage subscriptions/bookmarks/drafts/attachments?

Post Reply