[RFC|Merged] notification box

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Post Reply
User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: [RFC] notification box

Post by Dragosvr92 » Mon Dec 31, 2012 10:44 am

Hmm.. Good question !
I think the block should be a link. You can access the user link and message/notification link from the main notification block.
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
keith10456
Registered User
Posts: 523
Joined: Sat Apr 22, 2006 10:29 pm
Contact:

Re: [RFC] notification box

Post by keith10456 » Mon Dec 31, 2012 9:39 pm

TheKiller wrote:Hmm.. Good question !
I think the block should be a link. You can access the user link and message/notification link from the main notification block.
Agreed... In my opinion the whole block should be a link. Doing so will make it very mobile (phones, tablets, etc) friendly.

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] notification box

Post by EXreaction » Tue Jan 01, 2013 4:16 am

It already is.

User avatar
keith10456
Registered User
Posts: 523
Joined: Sat Apr 22, 2006 10:29 pm
Contact:

Re: [RFC] notification box

Post by keith10456 » Thu Jan 03, 2013 12:06 am

EXreaction wrote:It already is.
Glad to hear it!

shoes22
Posts: 33
Joined: Tue Jul 11, 2006 9:20 pm

Re: [RFC] notification box

Post by shoes22 » Tue Jan 29, 2013 9:52 pm

Hey, thanks for the hard work. I'm trying to test this out, and I'm getting a fatal error when trying to install and populate the tables. It has to do with the key length.
Here's what I get:

Code: Select all

install_install.php [ 1169 ]
SQL : CREATE TABLE phpbb_user_notifications ( item_type varchar(255) DEFAULT '' NOT NULL, item_id mediumint(8) UNSIGNED DEFAULT '0' NOT NULL, user_id mediumint(8) UNSIGNED DEFAULT '0' NOT NULL, method varchar(255) DEFAULT '' NOT NULL, notify tinyint(1) UNSIGNED DEFAULT '1' NOT NULL, PRIMARY KEY (item_type, item_id, user_id, method) ) CHARACTER SET `utf8` COLLATE `utf8_bin`
Specified key was too long; max key length is 1000 bytes

User avatar
RMcGirr83
Registered User
Posts: 357
Joined: Fri Mar 09, 2007 1:51 am
Contact:

Re: [RFC] notification box

Post by RMcGirr83 » Tue Jan 29, 2013 10:36 pm

utf8 uses 3 bytes per character, latin1 uses 1 byte per character. I am not sure if item_type and method need a varchar of 255.
Do not hire Christian Bullock he won't finish the job and will keep your money

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] notification box

Post by EXreaction » Wed Jan 30, 2013 3:17 am

What database system and version are you using?

User avatar
Meis2M
Registered User
Posts: 427
Joined: Fri Apr 23, 2010 10:18 am
Contact:

Re: [RFC] notification box

Post by Meis2M » Wed Jan 30, 2013 1:18 pm

when notification system merge?

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] notification box

Post by EXreaction » Wed Jan 30, 2013 3:14 pm

When someone reviews it.

shoes22
Posts: 33
Joined: Tue Jul 11, 2006 9:20 pm

Re: [RFC] notification box

Post by shoes22 » Wed Jan 30, 2013 11:14 pm

EXreaction wrote:What database system and version are you using?
I'm using MySQL with MySQLi, version 5.1.65.

Like RmCGirr83 pointed out, the problem stems from all four columns being primary keys, as that exceeds 1000 bytes in UTF-8.
However, I was able to bypass this issue by importing the table manually (not from install) and changing the 2 varchar columns to varbinary.

Post Reply