[RFC|Merged] notification box

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Post Reply
User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] notification box

Post by EXreaction »

That sounds like another phpBB bug. This does not modify any of the core code except where notifications take place, no action phpBB performs should change because of this.

I will check out that issue tomorrow.

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] notification box

Post by EXreaction »

oddfish wrote:Another issue.
Admin approves a topic.
Global Moderator logs in and there is a new notification to approve the very same topic, unread. Of course there is no topic to approve.
I cannot reproduce this, could you try it again?

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] notification box

Post by EXreaction »

Other than any new bugs I am not aware of, I'd say this is complete for prosilver.

I do have to make subsilver2 templates, but that's all that I have on my to-do list

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] notification box

Post by EXreaction »

Subsilver2 is now supported, this PR is all ready to review for merging.

keith10456
Registered User
Posts: 523
Joined: Sat Apr 22, 2006 10:29 pm
Contact:

Re: [RFC] notification box

Post by keith10456 »

Looking good!

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] notification box

Post by EXreaction »

Thanks :)

User avatar
oddfish
Registered User
Posts: 110
Joined: Tue Mar 27, 2007 5:53 am
Location: on my way home
Contact:

Re: [RFC] notification box

Post by oddfish »

EXreaction wrote:
oddfish wrote:Another issue.
Admin approves a topic.
Global Moderator logs in and there is a new notification to approve the very same topic, unread. Of course there is no topic to approve.
I cannot reproduce this, could you try it again?
Yeah, I can be reproduce this and confirmed using g077c526 fresh install.
  1. Moderator approves a topic in the MCP (not via notification), Admin logs in and there is a new notification, unread, to approve that topic.
  2. Admin approves a topic (again MCP). Notification still shows a new topic unread to approve.
Subsilver2 notification has a blank square beside each notification which is for avatars? I'm not using an avatar.

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] notification box

Post by EXreaction »

I will try to reproduce it again.

Subsilver2 should now not display a blank square if the user does not have an avatar.

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] notification box

Post by MichaelC »

There should probably be a wiki article on this (how to use it in extensions).
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] notification box

Post by EXreaction »

Yes, once it is in a final form (if anything else needs to be changed) and merged I will do that. :)

Post Reply