As a proper fix for http://tracker.phpbb.com/browse/PHPBB3-9091 and for other reasons outlined in http://tracker.phpbb.com/browse/PHPBB3-9746 etc. we came up with some normalisation for internet protocol addresses.
The changeset is medium-sized, therefore I'd like to ask for comments and reviews.
Tracker Ticket: http://tracker.phpbb.com/browse/PHPBB3-9746
Proposed Patch: http://github.com/bantu/phpbb3/compare/ ... icket/9746
I'm also pretty sure I'm missing some locations where phpbb_ip_normalise() should be called.
[RFC|Merged] Normalise internet protocol version 6 addresses
-
bantu
- 3.0 Release Manager
- Posts: 557
- Joined: Thu Sep 07, 2006 11:22 am
- Location: Karlsruhe, Germany
- Contact:
Re: [RFC] Normalise internet protocol version 6 addresses
Set to awaiting merge.
-
bantu
- 3.0 Release Manager
- Posts: 557
- Joined: Thu Sep 07, 2006 11:22 am
- Location: Karlsruhe, Germany
- Contact:
Re: [RFC] Normalise internet protocol version 6 addresses
We should probably normalise IP addresses that are already in the database. It should be possible to select all ip addresses containing the character ":" from all tables.