[RFC] Define max-width for prosilver

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Locked
User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 788
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: Define max-width for prosilver

Post by hanakin » Fri Jul 04, 2014 4:19 pm

they do in safari, not sure what VSE is using, but even in chrome I would like to see more than 12px on the bottom

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: Define max-width for prosilver

Post by VSE » Fri Jul 04, 2014 4:19 pm

PayBas wrote:I agree that maybe 12/15px is odd (although hardly a big problem), but which browser are you using?

The rounded corners at the bottom do not reach the bottom of my screen. There's a margin there.
Safari. But that shouldn't really matter as there is now browser inconsistency. it's a byproduct of this change:
https://github.com/phpbb/phpbb/pull/268 ... a8bfbbcL62
Has an irascible disposition.

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: Define max-width for prosilver

Post by VSE » Fri Jul 04, 2014 4:35 pm

Problem in safari now comes from the current changes mixed with: html height: 101%

Is the scrollbar jump still really an issue anymore (it's not in Macs, we have hidden scrollbars)?

if not, remove html height: 101%

-or-

Put back padding: 12px 0; on the body and remove the 12px margins added to wrap.

This should fix it:
https://github.com/phpbb/phpbb/pull/2694
Has an irascible disposition.

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: Define max-width for prosilver

Post by VSE » Fri Jul 04, 2014 9:28 pm

Just a thought, wouldn't it be cleaner to not have rounded borders and top/bottom padding/margins:
Screen Shot 2014-07-04 at 2.26.21 PM.png
(277.37 KiB) Downloaded 566 times
Has an irascible disposition.

User avatar
Louis7777
Registered User
Posts: 378
Joined: Fri Apr 04, 2014 12:32 am

Re: Define max-width for prosilver

Post by Louis7777 » Fri Jul 04, 2014 9:43 pm

VSE wrote:Another thought, wouldn't it be cleaner to not have rounded borders and top/bottom padding/margins:
Screen Shot 2014-07-04 at 2.26.21 PM.png
Please change the BG color first... :cry:

User avatar
keith10456
Registered User
Posts: 523
Joined: Sat Apr 22, 2006 10:29 pm
Contact:

Re: Define max-width for prosilver

Post by keith10456 » Fri Jul 04, 2014 10:14 pm

VSE wrote:Just a thought, wouldn't it be cleaner to not have rounded borders and top/bottom padding/margins:
Screen Shot 2014-07-04 at 2.26.21 PM.png
Disagree... Looks better as is.

User avatar
Sumanai
Registered User
Posts: 95
Joined: Sat Aug 31, 2013 11:12 am

Re: Define max-width for prosilver

Post by Sumanai » Sat Jul 05, 2014 2:46 am

VSE wrote: if not, remove html height: 101%
Why not? Is there an easier way to prevent scroll bar jump issues on PCs:

Code: Select all

html {
    height: 100%;
    overflow-y: scroll;
}
Sorry for my English.

User avatar
PayBas
Registered User
Posts: 305
Joined: Tue Jul 29, 2008 6:08 pm
Contact:

Re: Define max-width for prosilver

Post by PayBas » Sat Jul 05, 2014 7:48 am

Sumanai wrote:
VSE wrote: if not, remove html height: 101%
Why not? Is there an easier way to prevent scroll bar jump issues on PCs:

Code: Select all

html {
    height: 100%;
    overflow-y: scroll;
}
This is from 8 Apr 2007.
Always show a scrollbar for short pages - stops the jump when the scrollbar appears
I agree that we could probably do away with the height altogether and use the overflow-y.

Would need some extensive browser testing though.

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: Define max-width for prosilver

Post by VSE » Sat Jul 05, 2014 3:54 pm

PayBas wrote:I agree that we could probably do away with the height altogether and use the overflow-y.

Would need some extensive browser testing though.
I've used the overflow-y technique instead of height: 101% in the past with success.
Has an irascible disposition.

User avatar
mrgtb
Registered User
Posts: 217
Joined: Wed Nov 28, 2007 10:09 pm

Re: Define max-width for prosilver

Post by mrgtb » Sun Jul 06, 2014 12:31 pm

Would also like to see the gradient.gif removed that gets used on forum listings. On my forum I've made it a fully transparent image instead so you don't get that gradient effect shown, looks cleaner and better like topic listings not using it. When you have different category sections (with some containing more forums under it than other categories). That gradient background used on forums listed under each CAT can look different shades, darker for some CAT's with less forums - lighter for other CAT's with more listed forums under it.

It doesn't have a same uniformed look on forum home (with forums listed under CAT) because of it. As the image below shows you because 2nd CAT has many more forums listed under it than first one - making the lighter part of the gradient image be used for those forums.
Snap1.png
Snap1.png (62.07 KiB) Viewed 5320 times
How it looks on my forum using a fully transparent gradient.gif image to stop that happening.
2.PNG
(79.86 KiB) Downloaded 425 times
Last edited by mrgtb on Sun Jul 06, 2014 1:05 pm, edited 1 time in total.

Locked