Google+ Delete

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The current feature release of phpBB 3 is 3.3/Proteus.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.3.x. If you need support for phpBB 3.3.x please visit the 3.3.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Post Reply
User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1867
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: Google+ Delete

Post by DavidIQ »

Should just create a ticket in the tracker for that.
Image
User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 941
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: Google+ Delete

Post by hanakin »

or not we are alrady tracking this its already being revamped for 3.3
Donations welcome via Paypal Image
User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1867
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: Google+ Delete

Post by DavidIQ »

Ah ok. Which ticket is it?
Image
User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 941
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: Google+ Delete

Post by hanakin »

had to close the original PR as we changed things too much and needed to wait until the svg tools were in place but here is the ticket https://tracker.phpbb.com/browse/PHPBB3-15148
Donations welcome via Paypal Image
User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1867
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: Google+ Delete

Post by DavidIQ »

Your original pr and associated ticket do not cover removal of the actual fields from the system. So unless you're going to do that (create a migration, possibly remove files, etc.) then I would recommend a separate ticket be created for that non-style work that will be needed.
Image
User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 941
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: Google+ Delete

Post by hanakin »

correct it did not there was a topic about this on here as well that we disscussed rework them forget where. But based on the way we would have to impliment the new icons we would need to do some refactoring anyway as the way it currently works some of the icons are hardcoded from the db and some are not and we wanted it to be more uniform and handled cleaner without hardcoded values

found it: https://area51.phpbb.com/phpBB/viewtopi ... 31&t=51521
Donations welcome via Paypal Image
User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 941
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: Google+ Delete

Post by hanakin »

Donations welcome via Paypal Image
Post Reply