Notifications in 3.2

[david63]

I know that there have been some changes to the notification system in 3.2 - although I cannot say that I have seen any documentation as to what has changed.

I am struggling with notifications in 3.2 (to be honest I was struggling with notifications in 3.1 - but that's another story!). With any notification created by an extension in 3.2 I keep coming up with the same error messageThe service definition "" does not exist. - this is occurring not only with my extensions but with the Board Rules extension.

This is not a particularly helpful error message and even with the development error reporting there are no clues (well not to me) as to what is causing this error.

Taking the Board Rules as an example - the same code works fine on 3.1, so my question is what has changed to cause this error - or is it a bug?

[DavidIQ]

Are you getting this error while using the 3.2 branch from the Board Rules extension repo?

[david63]

Are you getting this error while using the 3.2 branch from the Board Rules extension repo?

No it's with the released version - I will take a look at the repro one (did not know that there was one)

Edit: When I used the version from the rep[ro (1.0.4-dev) I started getting other errors

Code: Select all

Catchable Fatal Error: Argument 1 passed to phpbb\notification\type\base::__construct() must implement interface phpbb\db\driver\driver_interface, instance of phpbb\user_loader given, called in C:\htdocs\phpbb_dev\ext\phpbb\boardrules\notification\boardrules.php on line 43 and defined

After fixing these (there were four altogether) I then got the The service definition "" does not exist. again

[DavidIQ]

Edit: When I used the version from the rep[ro (1.0.4-dev) I started getting other errors

There is no such branch in the Board Rules extension repo:
https://github.com/phpbb-extensions/boardrules/branches

[david63]

There is no such branch in the Board Rules extension repo:

There is - it is the Master branch.

Now that you have pointed me to the 3.2 version I am making headway - I have managed to get a notification to work, albeit not as I want it to but it is now a work in progress

[rxu]

Matt was pointing out some 3.2 upgrade notes (notifications included) here: https://www.phpbb.com/community/viewtop ... &t=2349131

[david63]

Matt was pointing out some 3.2 upgrade notes (notifications included) here: https://www.phpbb.com/community/viewtop ... &t=2349131

I had seen that but, as I am finding out, there are a lot more changes to notifications than are mentioned in that topic.

[rxu]

That's true. F.e. notifications_table injection was removed from user notifications.
For 3.2, the parent instruction can be used for notification service definition instead of arguments list, f.e. https://github.com/phpbb-extensions/boa ... ml#L72-L79

The commit with notification changes for 3.2 is here:
https://github.com/phpbb-extensions/boa ... ml#L72-L79

[david63]

For the record, and for anybody having the same problem, the original error of The service definition "" does not exist. was caused by this line in the find_users_for_notification() function

Code: Select all

$users[$row['user_id']] = array()

which has been replaced with

Code: Select all

$users[$row['user_id']] = $this->notification_manager->get_default_methods();