[RFC][PHPBB3-14596] 3.1.x - Installation denied if PHP >=7

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The current feature release of phpBB 3 is 3.3/Proteus.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.3.x. If you need support for phpBB 3.3.x please visit the 3.3.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
User avatar
3Di
Registered User
Posts: 951
Joined: Tue Nov 01, 2005 9:50 pm
Location: Milano 🇮🇹 Frankfurt 🇩🇪
Contact:

Re: [RFC] 3.1.x - Installation denied if PHP >=7

Post by 3Di »

:)
But's not finished here guys.. :P

There will be something or someone against my wishes, a sort of macumba.. :evil: :lol:

I cloned into my PC the phpBB github repository using

Code: Select all

git clone https://github.com/phpbb/phpbb.git
So what?
Well, there are not the files I need to modify before to create the new PR. :mrgreen:
For the composer.phar's lovers: Yes, I also did..

Code: Select all

cd phpbb
composer.phar install
Have a look please to the resulting install folder (nothing changed there, composer.phar install or not)
cloned-phpbb-1.png
@God @anybodyelse @whateveryouwant
#whatelsehaveitodo #navysealspleasecomehere

etc.. :)
🆓 Free support for our extensions also provided here: phpBB Studio
🚀 Looking for a specific feature or alternative option? We will rock you!
Please PM me only to request paid works. Thx. Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user º Extensions, Scripts, MOD porting, Update/Upgrades

CHItA
Development Team
Development Team
Posts: 169
Joined: Thu Mar 12, 2015 1:43 pm
Location: Budapest, Hungary

Re: [RFC] 3.1.x - Installation denied if PHP >=7

Post by CHItA »

1) Clone your own fork.
2) make the changes
3) commit them (use the right commit message format)
4) push your branch to your fork
5) go to github.com/phpbb/phpbb and create a pull request (you will see a button for it on github)

User avatar
3Di
Registered User
Posts: 951
Joined: Tue Nov 01, 2005 9:50 pm
Location: Milano 🇮🇹 Frankfurt 🇩🇪
Contact:

Re: [RFC] 3.1.x - Installation denied if PHP >=7

Post by 3Di »

I already did that. (I cloned phpBB three times as you can see into my attachment (top in the folder's list))

The install folder is not a carbon copy of the originals on github.

That's why I am asking.. try yourself, please. TIA. :)
🆓 Free support for our extensions also provided here: phpBB Studio
🚀 Looking for a specific feature or alternative option? We will rock you!
Please PM me only to request paid works. Thx. Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user º Extensions, Scripts, MOD porting, Update/Upgrades

User avatar
3Di
Registered User
Posts: 951
Joined: Tue Nov 01, 2005 9:50 pm
Location: Milano 🇮🇹 Frankfurt 🇩🇪
Contact:

Re: [RFC] 3.1.x - Installation denied if PHP >=7

Post by 3Di »

My environment is:

Win7 - up-to date
EasyPHP-DevServer-14VC11 - up-to-date
git - up-to-date
TortoiseGit - up-to-date
Composer (for win) - up-to-date
🆓 Free support for our extensions also provided here: phpBB Studio
🚀 Looking for a specific feature or alternative option? We will rock you!
Please PM me only to request paid works. Thx. Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user º Extensions, Scripts, MOD porting, Update/Upgrades

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1904
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] 3.1.x - Installation denied if PHP >=7

Post by DavidIQ »

3Di wrote: Wed Apr 20, 2016 10:41 pm I already did that. (I cloned phpBB three times as you can see into my attachment (top in the folder's list))

The install folder is not a carbon copy of the originals on github.

That's why I am asking.. try yourself, please. TIA. :)
You said and showed you cloned the phpBB repo but you need to clone your fork of the phpBB repo, which is not the same thing nor is it the same .git address in the command.
Image

User avatar
3Di
Registered User
Posts: 951
Joined: Tue Nov 01, 2005 9:50 pm
Location: Milano 🇮🇹 Frankfurt 🇩🇪
Contact:

Re: [RFC] 3.1.x - Installation denied if PHP >=7

Post by 3Di »

DavidIQ wrote: Thu Apr 21, 2016 2:30 am
3Di wrote: Wed Apr 20, 2016 10:41 pm I already did that. (I cloned phpBB three times as you can see into my attachment (top in the folder's list))

The install folder is not a carbon copy of the originals on github.

That's why I am asking.. try yourself, please. TIA. :)
You said and showed you cloned the phpBB repo but you need to clone your fork of the phpBB repo, which is not the same thing nor is it the same .git address in the command.
Sorry,
I would have been more clear..

on github I have a clone of phpBB that's up-to-date.

1 - I cloned my fork using
git clone https://github.com/3D-I/phpbb.git

install-my_fork-1.png

2 - I cloned the original phpBB using
git clone https://github.com/phpbb/phpbb.git

3 - I cloned the original phpBB using a mirror
git clone https://github.com/phpbb/phpbb.git --mirror
the mirror was just a try - de-facto - but actually we do not need such a mirror because is another kind of cloning.,

About 1 and 2 : nothing differs, there on github I have the install folder as it should be but into my forked local repositories.. I hope I have been more clear. Thanks.

The issue is the install folder, the language one is complete instead.

missing-install-1.png


Here's my fork https://github.com/3D-I/phpbb

Regards. :)
🆓 Free support for our extensions also provided here: phpBB Studio
🚀 Looking for a specific feature or alternative option? We will rock you!
Please PM me only to request paid works. Thx. Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user º Extensions, Scripts, MOD porting, Update/Upgrades

Nicofuma
3.2 Release Manager
3.2 Release Manager
Posts: 299
Joined: Sun Apr 13, 2014 1:40 am
Location: Paris

Re: [RFC] 3.1.x - Installation denied if PHP >=7

Post by Nicofuma »

You need to change the branch. Here you are on master (the default.when cloning) and you need to be on 3.1.x for your patch
Member of the phpBB Development-Team
No Support via PM

User avatar
3Di
Registered User
Posts: 951
Joined: Tue Nov 01, 2005 9:50 pm
Location: Milano 🇮🇹 Frankfurt 🇩🇪
Contact:

Re: [RFC] 3.1.x - Installation denied if PHP >=7

Post by 3Di »

Thanks for the inspiration about branches @Nicofuma. :)

That's what I did:

1 - deleted my fork
2 - went to the phpbb's repo and sat it to the master branch
3 - forked again the phpbb repo
4 - forked then MY fork into local (my PC)

at this time the install folder was complete..

5 - created a branch from 3.1.x on my fork (patch-1)
6 - edited those two files with a good IDE (UTF8-no bom)
7 - committed my changes into my new branch and pushed them over my github fork
8 - went to my fork over there at github
9 - created the new PR against phpbb

here we go: https://github.com/phpbb/phpbb/pull/4300
install-deny-the_end-1.png

The issue it was IMHO about the phpBB's repo being sat to the 3.1.x branch as per default but we need to fork the MASTER branch.. anyway....

I won the Top PRs' Locker Of The Month this time... :geek: :) :P

Thanks everybody for the patience. ;)
🆓 Free support for our extensions also provided here: phpBB Studio
🚀 Looking for a specific feature or alternative option? We will rock you!
Please PM me only to request paid works. Thx. Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user º Extensions, Scripts, MOD porting, Update/Upgrades

Nicofuma
3.2 Release Manager
3.2 Release Manager
Posts: 299
Joined: Sun Apr 13, 2014 1:40 am
Location: Paris

Re: [RFC][PHPBB3-14596] 3.1.x - Installation denied if PHP >=7

Post by Nicofuma »

with github and tortoise git you can change the current branch. On github it is a dropdown near the "New pull request" button (and you can always select any branch that exists, and when you fork the core you always have all the branch of the core available. After forking phpbb/phpbb you have to update your own fork manually. You can check github documentation about that)
Member of the phpBB Development-Team
No Support via PM

User avatar
3Di
Registered User
Posts: 951
Joined: Tue Nov 01, 2005 9:50 pm
Location: Milano 🇮🇹 Frankfurt 🇩🇪
Contact:

Re: [RFC][PHPBB3-14596] 3.1.x - Installation denied if PHP >=7

Post by 3Di »

Nicofuma wrote: Thu Apr 21, 2016 3:54 pm with github and tortoise git you can change the current branch.
Yes, correct.
Nicofuma wrote: Thu Apr 21, 2016 3:54 pmOn github it is a dropdown near the "New pull request" button (and you can always select any branch that exists, and when you fork the core you always have all the branch of the core available.
Yes, that's what I did this time before to fork it again though, else the install folder it wasn't complete,
branches-phpbb-1.png
3Di wrote: Thu Apr 21, 2016 3:14 pm 2 - went to the phpbb's repo and sat it to the master branch
3 - forked again the phpbb repo
4 - forked then MY fork into local (my PC)

at this time the install folder was complete..
Nicofuma wrote: Thu Apr 21, 2016 3:54 pmAfter forking phpbb/phpbb you have to update your own fork manually. You can check github documentation about that)
Yes, correct.

I am in any case happy to have a local fork where to work on, we are discussing about details and I am also very glad to participate and learn. Though I believe that should be noted that if you do not set the phpbb's repository to the master branch prior to fork it you will get a not carbon-copy of it. At least is what I learnt from this lesson.
🆓 Free support for our extensions also provided here: phpBB Studio
🚀 Looking for a specific feature or alternative option? We will rock you!
Please PM me only to request paid works. Thx. Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user º Extensions, Scripts, MOD porting, Update/Upgrades

Post Reply