Missing icon image.....?

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The next feature release of phpBB 3 will be 3.3/Proteus.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.2.x. If you need support for phpBB 3.2.x please visit the 3.2.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Post Reply
User avatar
spaceace
Registered User
Posts: 12
Joined: Thu Dec 04, 2014 4:33 pm
Location: Ontario Canada
Contact:
Contact spaceace

Re: Missing icon image.....?

Post by spaceace » Wed Mar 11, 2015 4:23 pm

i personally can't stand font awesome but won't have much say in it :(

but i would hope that it will be local by default in the case of something going wrong with the connection to the external site. otherwise you guys will get flooded with issues about no icons showing ;)
Top
User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1830
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:
Contact DavidIQ

Re: Missing icon image.....?

Post by DavidIQ » Wed Mar 11, 2015 6:46 pm

spaceace wrote:but i would hope that it will be local by default in the case of something going wrong with the connection to the external site. otherwise you guys will get flooded with issues about no icons showing ;)
Right, which is why we don't enable CDN usage for jQuery by default. ;)
Image
Top
User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 905
Joined: Sat Dec 25, 2010 9:02 pm
Contact:
Contact hanakin

Re: Missing icon image.....?

Post by hanakin » Sun Mar 15, 2015 1:37 pm

spaceace wrote:i personally can't stand font awesome but won't have much say in it :(

but i would hope that it will be local by default in the case of something going wrong with the connection to the external site. otherwise you guys will get flooded with issues about no icons showing ;)
it does not really matter as to the preference of the specific icons we choose. It will be implemented in a standard form meaning you can easily swap out icons for another. It will be a completely self contained module. Font-Awesome was chosen do to its highly active user base and compatibility of licensing not to mention the amount of icons that are supported. It beats all other competitors hands down in those two areas.

As for the implementation we are still working out some details. But It will be handled differently than jquery as its css not js so their are subtle differences to consider. The best way to handle this is still being discussed, as their are a lot of things to consider.

The current way we include jquery is also not necessarily the best method as it should be handle via fallback rather than setting. But thats a discussion for another day
Donations welcome via Paypal Image
Top
User avatar
Volksdevil
Registered User
Posts: 84
Joined: Tue Sep 04, 2012 2:17 pm
Contact:
Contact Volksdevil

Re: Missing icon image.....?

Post by Volksdevil » Tue Mar 17, 2015 3:20 am

Really glad to hear that Font Awesome will definitely be included! I've been using it from way back on 3.0.x.
Top
M.O.B.
Registered User
Posts: 29
Joined: Sat Jan 22, 2005 11:17 pm

Re: Missing icon image.....?

Post by M.O.B. » Sun Mar 29, 2015 6:34 am

icon_search_adv.gif
Ah! Since I dabble in style making, I was searching all over the place to see what the file looked like. Glad I found this.

Has it been already reported to be removed?
Image
Top
User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1830
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:
Contact DavidIQ

Re: Missing icon image.....?

Post by DavidIQ » Sun Mar 29, 2015 1:24 pm

Yes...
https://github.com/phpbb/phpbb/pull/3425
Image
Top
Post Reply

Return to “[3.x] Discussion”