Smiley and Whos Onlike pop-up boxes are making styling difficult

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The next feature release of phpBB 3 will be 3.3/Proteus.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.2.x. If you need support for phpBB 3.2.x please visit the 3.2.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Nicofuma
3.2 Release Manager
3.2 Release Manager
Posts: 299
Joined: Sun Apr 13, 2014 1:40 am
Location: Paris

Re: Smiley and Whos Onlike pop-up boxes are making styling difficult

Post by Nicofuma »

mrgtb wrote:BUMP!

Hmm, is this ever going to get fixed? I reported it in tracker 2 weeks ago and nobody assigned to it yet.
You also could send a PR yourself.
Member of the phpBB Development-Team
No Support via PM

User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 916
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: Smiley and Whos Onlike pop-up boxes are making styling difficult

Post by hanakin »

their are alos more areas related to this than just the two referenced instances
Donations welcome via Paypal Image

mrgtb
Registered User
Posts: 221
Joined: Wed Nov 28, 2007 10:09 pm

Re: Smiley and Whos Onlike pop-up boxes are making styling difficult

Post by mrgtb »

hanakin wrote:their are alos more areas related to this than just the two referenced instances
Wasn't aware of that. What other areas get affected?

User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 916
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: Smiley and Whos Onlike pop-up boxes are making styling difficult

Post by hanakin »

Find Members and messaging
Donations welcome via Paypal Image

mrgtb
Registered User
Posts: 221
Joined: Wed Nov 28, 2007 10:09 pm

Re: Smiley and Whos Onlike pop-up boxes are making styling difficult

Post by mrgtb »

Ah right, never crossed my mind about that using a pop-up box in admin cp.

mrgtb
Registered User
Posts: 221
Joined: Wed Nov 28, 2007 10:09 pm

Re: Smiley and Whos Onlike pop-up boxes are making styling difficult

Post by mrgtb »

Nicofuma wrote:
mrgtb wrote:BUMP!

Hmm, is this ever going to get fixed? I reported it in tracker 2 weeks ago and nobody assigned to it yet.
You also could send a PR yourself.
I don't really know a solution to the problem. I did mention "maybe" giving the pop-up boxes there own separate CSS style elements, so they can be styled separate instead of inheriting forum background e.t.c. But whether or not that's a good idea I've honestly no idea, just a thought off the top of my head.

Others no doubt may come up with much better solutions.

User avatar
tbackoff
Registered User
Posts: 180
Joined: Sat Jun 12, 2010 3:25 am

Re: Smiley and Whos Onlike pop-up boxes are making styling difficult

Post by tbackoff »

Just a note - this happens with any pop-up boxes (like the "Find a member" pop-up in the ACP).

EDIT: Didn't see page 2. :|

User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 916
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: Smiley and Whos Onlike pop-up boxes are making styling difficult

Post by hanakin »

Donations welcome via Paypal Image

mrgtb
Registered User
Posts: 221
Joined: Wed Nov 28, 2007 10:09 pm

Re: Smiley and Whos Onlike pop-up boxes are making styling difficult

Post by mrgtb »

I read it and left a comment. See you made some more changes since. Last I looked it was only one file edit.

Can see you made some of the popup boxes so they are bigger on loading. Not tested the changes yet and will wait to see what happens first with RC3, if they accept it or go another route with it. I saw mentioned in comments about adding margin/padding back to pop-up boxes removed previously like phpBB 3.0 uses it. Would like to see that added back to the pop-up boxes as well. they don't look as good as in 3.0 without that margin/padding used.

User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 916
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: Smiley and Whos Onlike pop-up boxes are making styling difficult

Post by hanakin »

they are all consistent size of 750px no to prevent them from going to collapse mode as well as standardized all the h2 tags appearance.
Screenshot 2014-07-31 08.43.20.png
(23.88 KiB) Downloaded 372 times
Screenshot 2014-07-31 08.44.19.png
(16.81 KiB) Downloaded 372 times
Screenshot 2014-07-31 08.47.38.png
(45.84 KiB) Downloaded 372 times
Donations welcome via Paypal Image

Post Reply