[Define New Theme] 16. Better consistency & standards across the theme need to be created and enforced.

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The next feature release of phpBB 3 will be 3.3/Proteus.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.2.x. If you need support for phpBB 3.2.x please visit the 3.2.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
User avatar
keith10456
Registered User
Posts: 523
Joined: Sat Apr 22, 2006 10:29 pm
Contact:

Re: [Define New Theme] 16. Better consistency & standards across the theme need to be created and enforced.

Post by keith10456 » Sun Aug 03, 2014 7:59 pm

hanakin wrote:Progress Update: http://hanakin.github.io/phpBB-StyleGuide/

been trying to update this as much as I can. finally got all the common stuff put in and added icons as well. Next up buttons, then all the other elements and components
Wow! Awesome job!

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 841
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [Define New Theme] 16. Better consistency & standards across the theme need to be created and enforced.

Post by hanakin » Mon Sep 08, 2014 8:56 pm

REPO: https://github.com/hanakin/phpBB-StyleG ... index.html
DEMO: http://hanakin.github.io/phpBB-StyleGuide/

Updated the guide to allow for better modularity and versioning. All the components are now generated via their own html file as a test case and included in the overall index file.

I am using a JS port of TWIG to allow for better compatibility for porting over to phpBB.

Now that the core features of the framework are in place I can begin working on individual components. I will also rework the readme when I get a chance to better define the preferred requirements once everything is in place to allow for contribution on this to the community.
Louis7777 wrote:
brunoais wrote:It looks good but...
Could you please make the HTML easier to read (includes indenting) ? I'd like to read that also so that I can understand it better.
Yeah, big +1

Would it also be a good idea to add HTML comments? For example:

Code: Select all

<!-- OPEN JS SCRIPTS -->
<script type="text/javascript" src="//ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js"></script>
<script type="text/javascript">window.jQuery || document.write(unescape('%3Cscript src="./assets/javascript/jquery.min.js?assets_version=1730" type="text/javascript"%3E%3C/script%3E'));</script><script type="text/javascript" src="./assets/javascript/core.js?assets_version=1730"></script>


<script type="text/javascript" src="./styles/prosilver/template/forum_fn.js?assets_version=1730"></script>

<script type="text/javascript" src="./styles/prosilver/template/ajax.js?assets_version=1730"></script>
<!-- CLOSE JS SCRIPTS -->
Not really sure what is meant by making it easier to read? Everything is properly indented as of now using HTML Pretty, but It may not have been t the time of the comment and if thats the case disregard

User avatar
Louis7777
Registered User
Posts: 379
Joined: Fri Apr 04, 2014 12:32 am

Re: [Define New Theme] 16. Better consistency & standards across the theme need to be created and enforced.

Post by Louis7777 » Mon Sep 08, 2014 9:39 pm

^I mean comments like:

<!-- OPEN SECTION --> or <!-- BEGIN SECTION --> and <!-- CLOSE SECTION -->. "SECTION" could be header, navbar, forums, footer, js scripts etc.

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 841
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [Define New Theme] 16. Better consistency & standards across the theme need to be created and enforced.

Post by hanakin » Tue Sep 09, 2014 8:55 pm

Louis7777 wrote:^I mean comments like:

<!-- OPEN SECTION --> or <!-- BEGIN SECTION --> and <!-- CLOSE SECTION -->. "SECTION" could be header, navbar, forums, footer, js scripts etc.
I understood the comments bit but its redundant as all the sections have a descriptive ID. Was more referring to brunoais's comment about indentation

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 841
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [Define New Theme] 16. Better consistency & standards across the theme need to be created and enforced.

Post by hanakin » Thu Sep 11, 2014 4:47 am

Updated the Readme to briefly outline purpose,processes, and requirements. Their is still more documentation to follow.

As I wrap up the development for the core framework, and transition into the beginnings of creating the new theme. I have begun to make changes and outline requirements and processes for everyone to contribute to the project.

I will be posting a detailed roadmap soon that will outline the process and requirements once I feel the documentation is sufficient to bolster both communities involvement.

- Hanakin

User avatar
callumacrae
Former Team Member
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [Define New Theme] 16. Better consistency & standards across the theme need to be created and enforced.

Post by callumacrae » Fri Sep 12, 2014 12:51 pm

hanakin wrote:I am using a JS port of TWIG to allow for better compatibility for porting over to phpBB.
Why? You're using a project with zero stars.

mustache has 6,809 stars on its JS project, and they're both based on Django and Jinja2 so they're both pretty much exactly the same.
Made by developers, for developers!
My blog

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 841
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [Define New Theme] 16. Better consistency & standards across the theme need to be created and enforced.

Post by hanakin » Fri Sep 12, 2014 2:12 pm

not really familiar with js templating having not messed with them much. could not really find any decent resource to learn them. I look at it

Post Reply