[Define New Theme] 12. In-Depth Design study on each block of content semantics + modularity

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The next feature release of phpBB 3 will be 3.3/Proteus.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.2.x. If you need support for phpBB 3.2.x please visit the 3.2.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
User avatar
Sumanai
Registered User
Posts: 95
Joined: Sat Aug 31, 2013 11:12 am

Re: [Define New Theme] 12. In-Depth Design study on each block of content based on semantics

Post by Sumanai » Sat Jun 07, 2014 10:50 am

hanakin wrote: An icon is a piece of content that can be used in several ways and place throughout the html.
I do not agree. I think that icons apply to design.
hanakin wrote:you missed the point by declaring an icon element you are not restricting your self to an icon font having to be one way and a sprite based concept another. They both can utilize the same object.
I used the icon font for example. No problem instead use sprites to be even easier to replace them the text when it's needed. Can do for you an example, if you wish.
hanakin wrote:OOD
Please explain.
hanakin wrote:their is no such thing as a fictional situation when it comes to OOD its meant to be self contained and infinitely configurable. This actually comes in handy when working with complex icon concept like that of the forum imagesets
I do not see any need for more than two icons of a single button. If you need more, you can change the layout. You also have to change the layout from the outset.
I do not see the benefits.

We clearly not overpersuaded each other. I would like to hear the opinion of others in this regard.
Sorry for my English.

User avatar
callumacrae
Former Team Member
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [Define New Theme] 12. In-Depth Design study on each block of content based on semantics

Post by callumacrae » Sat Jun 07, 2014 10:53 am

hanakin wrote: all icons should be in one sprite. so count the number of icons and the fact that they are different sizes and used in different ways in prosilver. you will end up with a very complicated extremely large file full of a lot of white space. With mine all the icons fit on a single row with no spacing in between.
To be honest, I doubt this will make it into phpBB before HTTP 2.0 is supported in major browsers, and so using sprites would be an anti-pattern.
Made by developers, for developers!
My blog

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 855
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [Define New Theme] 12. In-Depth Design study on each block of content based on semantics

Post by hanakin » Sat Jun 07, 2014 1:01 pm

@callumacrae
mehe we will see. either way font-awesome will require it in 3.2.

@Sumani
OOD = Object Oriented Design

and icons are used in more places than just buttons, IE logos, headers, imagesets, etc... <-- this is why its its own object as it has several uses and as such is its own element

also give this a read
http://css-tricks.com/html-for-icon-font-usage/

and ask questions on the community side of the font-icon projects submit an issue with font-awsome to change it to your method and see what you get back!

User avatar
Sumanai
Registered User
Posts: 95
Joined: Sat Aug 31, 2013 11:12 am

Re: [Define New Theme] 12. In-Depth Design study on each block of content based on semantics

Post by Sumanai » Sat Jun 07, 2014 7:54 pm

hanakin wrote:and icons are used in more places than just buttons, IE logos, headers, imagesets, etc... <-- this is why its its own object as it has several uses and as such is its own element

also give this a read
http://css-tricks.com/html-for-icon-font-usage/

and ask questions on the community side of the font-icon projects submit an issue with font-awsome to change it to your method and see what you get back!
The language barrier does not allow me to understand this message, sorry.
Method using data-icon and content: attr (data-icon) liked me, thank you. Did not know that you can do so. Although not see any sense.
Sorry for my English.

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 855
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [Define New Theme] 12. In-Depth Design study on each block of content semantics + modularity

Post by hanakin » Sun Jun 08, 2014 9:35 am

its referring to the fact that when dealing with screen readers we need to provide the icon with its own markup as speak is not fully supported by all of them. and aria-hidden would apply to everything within the a tag if you do not have the <i> to apply it too in-order to prevent them from attempting to say the icon.

User avatar
Sumanai
Registered User
Posts: 95
Joined: Sat Aug 31, 2013 11:12 am

Re: [Define New Theme] 12. In-Depth Design study on each block of content semantics + modularity

Post by Sumanai » Sun Jun 08, 2014 11:39 am

I doubt that the reader will read the icon of style. However, I'm not sure.
Sorry for my English.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1787
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [Define New Theme] 12. In-Depth Design study on each block of content semantics + modularity

Post by DavidIQ » Sun Jun 08, 2014 12:21 pm

Sumanai wrote:I doubt that the reader will read the icon of style. However, I'm not sure.
It will not. This is why he is suggesting that the icon be a separate element instead of a stylesheet rendered icon.
Image

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 855
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [Define New Theme] 12. In-Depth Design study on each block of content semantics + modularity

Post by hanakin » Sun Jun 08, 2014 3:34 pm

The goal is for it to not be spoken as it obviously will be speaking a random character.

It will be spoken in some, but not others even when you have speak:no applied to the :before. You can test this in voiceover on a Mac. The goal is for the icon to not be spoken so in order to prevent this we need to also add aria-hidden. However we can not just apply it to the container as it stops everything in the containing element from being spoken. so we need the icon element in order to provide more control over the icon and the text separately.

weather we choose to apply the icon via css or via data-atribute is another discussion.

User avatar
Sumanai
Registered User
Posts: 95
Joined: Sat Aug 31, 2013 11:12 am

Re: [Define New Theme] 12. In-Depth Design study on each block of content semantics + modularity

Post by Sumanai » Sun Jun 08, 2014 7:06 pm

hanakin wrote:It will be spoken in some, but not others even when you have speak:no applied to the :before. You can test this in voiceover on a Mac.
Sounds reasonable. Admit your arguments.
I wonder how to relate to this specification and standards. But it does not matter if a screen reader violate them.
But I'm still against the additional element <span> around the text.
hanakin wrote:weather we choose to apply the icon via css or via data-atribute is another discussion.
Number of the next theme will be 12.1? :mrgreen:
Sorry for my English.

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 855
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [Define New Theme] 12. In-Depth Design study on each block of content semantics + modularity

Post by hanakin » Mon Jun 09, 2014 4:52 am

the span is required to be fully extensible as you can not hide the text without affecting the <i> without giving the text its own span element

Post Reply