[Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The next feature release of phpBB 3 will be 3.3/Proteus.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.1. If you need support for phpBB 3.1 please visit the 3.1.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Post Reply
User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 835
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by hanakin » Tue Sep 22, 2015 3:36 pm

The idea of using font-awsome was for the end-user as its easier to work with then svgs. Its used throughout countless frameworks. It provides very little overhead as it has its own CDN service. I originally left the discussion open on the best method to serve the icons with no input on here and the pr

To be honest yes font-icons may be on the way out and ultimately I would love to use SVG, however it will still be at least two years before the browsers that still have limitation dwindle off and the code changes for this at least make editing the icons a lot easier. This way we can plug and play a lot easier when that time comes
paulus wrote:
Tue Sep 22, 2015 7:56 am
The unread icons in viewtopic are no longer a different color as the read icons, making it impossible to see which post is unread.
@paulus can you please comment on the merged pr so I can see what exactly you're referring to.
https://github.com/phpbb/phpbb/pull/3851

User avatar
callumacrae
Former Team Member
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by callumacrae » Tue Sep 22, 2015 3:57 pm

hanakin wrote:
Tue Sep 22, 2015 3:36 pm
however it will still be at least two years before the browsers that still have limitation dwindle off
What are you referring to here?
Screen Shot 2015-09-22 at 16.55.34.png
http://caniuse.com/#feat=svg
Made by developers, for developers!
My blog

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 835
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by hanakin » Wed Sep 23, 2015 4:50 am

I am not speaking to basic support but more advanced functionality from a usability standpoint as working with svg sprites is limited in the ability to edit via css.

http://caniuse.com/#cats=SVG

Making it more cumbersome with apps when it comes to customizability for the end user when large amounts of icons are concerned.

I have not seen or come across any easy methods for manipulating svg sprites via css which means we would in turn be using use which again is even more cumbersome for the end user as its not easily BC

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by VSE » Wed Sep 23, 2015 4:42 pm

I think this Font Awesome PR also wound up breaking custom bbcode buttons:
Screen Shot 2015-09-23 at 9.41.14 AM.png
Has an irascible disposition.

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 835
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by hanakin » Wed Sep 23, 2015 5:14 pm

VSE wrote:
Wed Sep 23, 2015 4:42 pm
I think this Font Awesome PR also wound up breaking custom bbcode buttons
true I have a fix for it when i get time. Also noticed the color is sort of off on this aswell but can change that in the color pr i guess.

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by VSE » Wed Sep 23, 2015 9:02 pm

hanakin wrote:
Wed Sep 23, 2015 5:14 pm
VSE wrote:
Wed Sep 23, 2015 4:42 pm
I think this Font Awesome PR also wound up breaking custom bbcode buttons
true I have a fix for it when i get time. Also noticed the color is sort of off on this aswell but can change that in the color pr i guess.
Also the Quick Links Menu has been broken by this. On responsive views, FAQ, ACP, MCP or any other left sided nav links no longer collapse into the Quick Links menu, they just disappear now.

BBCode Buttons ticket: https://tracker.phpbb.com/browse/PHPBB3-14193
Quick Links Responsive: https://tracker.phpbb.com/browse/PHPBB3-14194
Plupload Attachments: https://tracker.phpbb.com/browse/PHPBB3-14195
Has an irascible disposition.

User avatar
JoshyPHP
Registered User
Posts: 360
Joined: Fri Jul 08, 2011 9:43 pm

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by JoshyPHP » Wed Sep 23, 2015 9:52 pm

For what it's worth, I feel like the post icons which are currently gray / orange / red would look better in desaturated blue / orange / red, slightly blended with the background color. Something like #F1C388 #ACC5DC and #C1506D.

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 835
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by hanakin » Thu Sep 24, 2015 4:35 am

VSE wrote:
Wed Sep 23, 2015 9:02 pm
Also the Quick Links Menu has been broken by this. On responsive views, FAQ, ACP, MCP or any other left sided nav links no longer collapse into the Quick Links menu, they just disappear now.
I also noticed that in responsive post buttons for logged in user do not collapse.
https://tracker.phpbb.com/browse/PHPBB3-14196
JoshyPHP wrote:
Wed Sep 23, 2015 9:52 pm
For what it's worth, I feel like the post icons which are currently gray / orange / red would look better in desaturated blue / orange / red, slightly blended with the background color. Something like #F1C388 #ACC5DC and #C1506D.
Maybe, im not sure that introducing more fractured colors is a good idea. Either way that probably belongs more in the color refactoring pr.
https://github.com/phpbb/phpbb/pull/3867

User avatar
callumacrae
Former Team Member
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by callumacrae » Thu Sep 24, 2015 11:12 am

Made by developers, for developers!
My blog

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by Pony99CA » Fri Sep 25, 2015 2:40 am

hanakin wrote:
Mon Sep 21, 2015 4:54 pm
Merged!
Is the merge why I'm no longer seeing the "last post", "first unread post", "quote", "report" and so on icons?

if so, this needs to be fixed soon or backed out.

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

Post Reply