[Define New Theme] 4. Reorganize, structure and rename contents within the theme based on standards

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The next feature release of phpBB 3 will be 3.3/Proteus.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.1. If you need support for phpBB 3.1 please visit the 3.1.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Senky Online
Extension Customisations
Extension Customisations
Posts: 299
Joined: Thu Jul 16, 2009 4:41 pm

Re: [Define New Theme] 4. Reorganize, structure and rename contents within the theme based on standards

Post by Senky » Wed Sep 10, 2014 3:12 pm

That would be the best, since site admins have no advantage having less files in their copy of phpBB...

User avatar
callumacrae
Former Team Member
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [Define New Theme] 4. Reorganize, structure and rename contents within the theme based on standards

Post by callumacrae » Fri Sep 12, 2014 12:55 pm

hanakin wrote:design <- design related files such as .ai or .psd files
Please put them in their own repo! Putting large binary resources in a code repository is how you end up with code repositories that are 150MB big. Every time you save a new version, the repository increases in size 2MB.
Made by developers, for developers!
My blog

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 826
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [Define New Theme] 4. Reorganize, structure and rename contents within the theme based on standards

Post by hanakin » Fri Sep 12, 2014 2:09 pm

@callumacrae it will be separated into only those that require it such as the gh-pages as their should not be many if any design files for anything else

User avatar
callumacrae
Former Team Member
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [Define New Theme] 4. Reorganize, structure and rename contents within the theme based on standards

Post by callumacrae » Fri Sep 12, 2014 2:19 pm

That will still hugely increase the size of the repo. What's wrong with a phpbb-assets repo?
Made by developers, for developers!
My blog

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 826
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [Define New Theme] 4. Reorganize, structure and rename contents within the theme based on standards

Post by hanakin » Fri Sep 12, 2014 2:50 pm

there is no design folder at the moment anyway in the current repos. This topic is about establishing a standard and in that regard their should always be a design folder located in your project folder near your img folder. It does not need to live in the repo.

Post Reply