Improve the "Attachment settings" in ACP

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The next feature release of phpBB 3 will be 3.3/Proteus.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.2.x. If you need support for phpBB 3.2.x please visit the 3.2.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Post Reply
User avatar
M.Gaetan89
Registered User
Posts: 64
Joined: Tue Jan 28, 2014 7:17 pm
Location: Divonne-les-Bains, France
Contact:

Improve the "Attachment settings" in ACP

Post by M.Gaetan89 »

Hello,

I just installed phpBB3.1-b2 and started to configure it and now I have a couple of suggestions for the "Attachment settings" in the ACP.
I have a couple of small suggestions, and if they are fine for I, I can create the tickets and PRs.

First, it would be nice to support bigger file size than Mib in the select menus, next to the max size fields. I think that at least "Total attachment quota" could use the Gib file size.
Second, why doesn't the "Minimum thumbnail file size" setting have the same select menu for the size ? The default value could then be "12 Kb" instead of "12000 Bytes". This is also true in "Avatar settings", for the "Maximum avatar file size" setting.

What do you think about these small improvments?

Gaëtan

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1846
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: Improve the "Attachment settings" in ACP

Post by DavidIQ »

For one of my sites I use shared hosting, which is cheap and reliable, and I get all of 1 GB of server space. Your "Total attachment quota" suggestion wouldn't work for that case and the many other admins in the same situation.
Image

User avatar
M.Gaetan89
Registered User
Posts: 64
Joined: Tue Jan 28, 2014 7:17 pm
Location: Divonne-les-Bains, France
Contact:

Re: Improve the "Attachment settings" in ACP

Post by M.Gaetan89 »

I am just suggesting to add the "Gb" option in the dropdown list. The admin would still be able to choose b, kb, or mb the same as before ;)

User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

Re: Improve the "Attachment settings" in ACP

Post by bantu »

Sure, these fields should also use the usual framework for generating filesize dropdowns. Feel free to create a ticket and fix it.

User avatar
M.Gaetan89
Registered User
Posts: 64
Joined: Tue Jan 28, 2014 7:17 pm
Location: Divonne-les-Bains, France
Contact:

Re: Improve the "Attachment settings" in ACP

Post by M.Gaetan89 »

I created the issue: PHPBB-12340 (I almost got issue 12345 :-P).
I will submit a PR as soon as I can.

keith10456
Registered User
Posts: 523
Joined: Sat Apr 22, 2006 10:29 pm
Contact:

Re: Improve the "Attachment settings" in ACP

Post by keith10456 »

@ M.Gaetan89 - Good idea... And thanks for implementing ;-)

User avatar
PayBas
Registered User
Posts: 305
Joined: Tue Jul 29, 2008 6:08 pm
Contact:

Re: Improve the "Attachment settings" in ACP

Post by PayBas »

Agreed. I don't think many boards would use it, but with the costs of hosting going down and down... it might be good, if nothing else... just to be future-proof.

Post Reply