Usage of vertical-align on Smileys.

Discuss features as they are added to the new version. Give us your feedback. Don't post bug reports, feature requests, support questions or suggestions here.
Forum rules
Discuss features as they are added to the new version. Give us your feedback. Don't post bug reports, feature requests, support questions or suggestions here. Feature requests are closed.
Post Reply
User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Usage of vertical-align on Smileys.

Post by Dragosvr92 » Sun Oct 30, 2011 10:49 pm

Hello, from when i have first seen a phpBB instalation it sort of bothered me that the smileys arent on the same straight line as the text.

Here is an example on what im babbling here.. :)

Code: Select all

<html>
<head>
<title>Smileys</title>
<style>
<!-- 
#smileys{
vertical-align: text-bottom;
} -->
</style>
</head>

<body>
<center><br /><br /><br /><br />
<strong>How it is on phpBB styles:</strong><br />
TEXT_<img width="15" height="17" title="Very Happy" alt=":D" src="http://area51.phpbb.com/phpBB/images/smilies/icon_mrgreen.gif"/>_TEXT
<br /><br />
<strong>How i would like it to be on phpBB styles:</strong><br />
TEXT_<img width="15" height="17" title="Very Happy" alt=":D" src="http://area51.phpbb.com/phpBB/images/smilies/icon_mrgreen.gif" id="smileys"/>_TEXT
</center>

</body>

 
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: Usage of vertical-align on Smileys.

Post by naderman » Mon Oct 31, 2011 12:23 pm

I think I agree, create a ticket and a patch?

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: Usage of vertical-align on Smileys.

Post by Dragosvr92 » Tue Nov 01, 2011 7:36 pm

naderman wrote:I think I agree, create a ticket and a patch?
http://tracker.phpbb.com/browse/PHPBB3-10438
Done :)

I would submit a patch, but i have no idea where is the HTML Code at. Some PHP file probably..
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
/a3
Registered User
Posts: 97
Joined: Mon Sep 20, 2010 6:44 am

Re: Usage of vertical-align on Smileys.

Post by /a3 » Wed Nov 02, 2011 7:45 pm

You should use class, not id. id means it will only be used once, classes are used across many elements.

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: Usage of vertical-align on Smileys.

Post by Dragosvr92 » Wed Nov 02, 2011 10:13 pm

/a3 wrote:You should use class, not id. id means it will only be used once, classes are used across many elements.
Thanks for your suggestion. This will be done in 3.1.X .....
It seems that it will be added when they will include a new BBCode system, as it will be easier to modify the smiley html code from the posts, and add a class or id.
Previous user: TheKiller
Avatar on Memberlist 1.0.3

Post Reply